diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c index b331f4c279..765d8992ea 100644 --- a/src/backend/access/heap/vacuumlazy.c +++ b/src/backend/access/heap/vacuumlazy.c @@ -159,9 +159,9 @@ typedef struct LVDeadTuples * ItemPointerData */ } LVDeadTuples; -#define SizeOfLVDeadTuples(cnt) \ - add_size((offsetof(LVDeadTuples, itemptrs)), \ - mul_size(sizeof(ItemPointerData), cnt)) +#define SizeOfLVDeadTuples (offsetof(LVDeadTuples, itemptrs)) +#define SizeOfDeadTuples(cnt) \ + add_size(SizeOfLVDeadTuples, mul_size(sizeof(ItemPointerData), cnt)) /* * Shared information among parallel workers. So this is allocated in the DSM @@ -2708,9 +2708,10 @@ compute_max_dead_tuples(BlockNumber relblocks, bool useindex) if (useindex) { - maxtuples = (vac_work_mem * 1024L) / sizeof(ItemPointerData); + maxtuples = ((vac_work_mem * 1024L) - SizeOfLVDeadTuplesHeader) / sizeof(ItemPointerData); maxtuples = Min(maxtuples, INT_MAX); - maxtuples = Min(maxtuples, MaxAllocSize / sizeof(ItemPointerData)); + maxtuples = Min(maxtuples, + (MaxAllocSize - SizeOfLVDeadTuples) / sizeof(ItemPointerData)); /* curious coding here to ensure the multiplication can't overflow */ if ((BlockNumber) (maxtuples / LAZY_ALLOC_TUPLES) > relblocks) @@ -2738,7 +2739,7 @@ lazy_space_alloc(LVRelStats *vacrelstats, BlockNumber relblocks) maxtuples = compute_max_dead_tuples(relblocks, vacrelstats->useindex); - dead_tuples = (LVDeadTuples *) palloc(SizeOfLVDeadTuples(maxtuples)); + dead_tuples = (LVDeadTuples *) palloc(SizeOfDeadTuples(maxtuples)); dead_tuples->num_tuples = 0; dead_tuples->max_tuples = (int) maxtuples; @@ -3146,7 +3147,7 @@ begin_parallel_vacuum(Oid relid, Relation *Irel, LVRelStats *vacrelstats, /* Estimate size for dead tuples -- PARALLEL_VACUUM_KEY_DEAD_TUPLES */ maxtuples = compute_max_dead_tuples(nblocks, true); - est_deadtuples = MAXALIGN(SizeOfLVDeadTuples(maxtuples)); + est_deadtuples = MAXALIGN(SizeOfDeadTuples(maxtuples)); shm_toc_estimate_chunk(&pcxt->estimator, est_deadtuples); shm_toc_estimate_keys(&pcxt->estimator, 1);