From a40b5e9b8abc5de3ea84ff0da08f84e1d7a63c11 Mon Sep 17 00:00:00 2001 From: Ajin Cherian Date: Tue, 9 Mar 2021 04:45:10 -0500 Subject: [PATCH v55] Fix apply worker empty prepare (dev logs). NOT TO BE COMMITTED. This patch is only for adding some developer logging which may help for debugging/testing the "Fix apply worker empty prepare" patch. --- src/backend/replication/logical/tablesync.c | 29 ++++++++++--- src/backend/replication/logical/worker.c | 66 ++++++++++++++++++++++------- 2 files changed, 74 insertions(+), 21 deletions(-) diff --git a/src/backend/replication/logical/tablesync.c b/src/backend/replication/logical/tablesync.c index 97fc399..f3984d4 100644 --- a/src/backend/replication/logical/tablesync.c +++ b/src/backend/replication/logical/tablesync.c @@ -282,6 +282,12 @@ process_syncing_tables_for_sync(XLogRecPtr current_lsn) { SpinLockAcquire(&MyLogicalRepWorker->relmutex); + elog(LOG, + "!!> process_syncing_tables_for_sync: state = '%c', current_lsn = %X/%X, relstate_lsn = %X/%X", + MyLogicalRepWorker->relstate, + LSN_FORMAT_ARGS(current_lsn), + LSN_FORMAT_ARGS(MyLogicalRepWorker->relstate_lsn)); + if (MyLogicalRepWorker->relstate == SUBREL_STATE_CATCHUP && current_lsn >= MyLogicalRepWorker->relstate_lsn) { @@ -1127,6 +1133,8 @@ FetchTableStates(bool *started_tx) ListCell *lc; SubscriptionRelState *rstate; + elog(LOG, "!!> FetchTableStates: Re-fetching the state list caches"); + /* Clean the old lists. */ list_free_deep(table_states_all); table_states_all = NIL; @@ -1149,6 +1157,7 @@ FetchTableStates(bool *started_tx) rstate = palloc(sizeof(SubscriptionRelState)); memcpy(rstate, cur_rstate, sizeof(SubscriptionRelState)); table_states_all = lappend(table_states_all, rstate); + elog(LOG, "!!> FetchTableStates: table_states_all - added Table relid %u with state '%c'", rstate->relid, rstate->state); /* List of only not-ready states */ if (cur_rstate->state != SUBREL_STATE_READY) @@ -1156,12 +1165,17 @@ FetchTableStates(bool *started_tx) rstate = palloc(sizeof(SubscriptionRelState)); memcpy(rstate, cur_rstate, sizeof(SubscriptionRelState)); table_states_not_ready = lappend(table_states_not_ready, rstate); + elog(LOG, "!!> FetchTableStates: table_states_not_ready - added Table relid %u with state '%c'", rstate->relid, rstate->state); } } MemoryContextSwitchTo(oldctx); table_states_valid = true; } + else + { + elog(LOG, "!!> FetchTableStates: Already up-to-date"); + } } /* @@ -1175,6 +1189,8 @@ AnyTablesyncInProgress() int count = 0; ListCell *lc; + elog(LOG, "!!> AnyTablesyncInProgress?"); + /* We need up-to-date sync state info for subscription tables here. */ FetchTableStates(&started_tx); @@ -1186,8 +1202,8 @@ AnyTablesyncInProgress() SubscriptionRelState *rstate = (SubscriptionRelState *) lfirst(lc); count++; - elog(DEBUG1, - "AnyTablesyncInProgress?: #%d. Table relid %u has state '%c'", + elog(LOG, + "!!> AnyTablesyncInProgress?: #%d. Table relid %u has state '%c'", count, rstate->relid, rstate->state); @@ -1204,6 +1220,7 @@ AnyTablesyncInProgress() if (rstate->state != SUBREL_STATE_SYNCDONE && rstate->state != SUBREL_STATE_READY) { + elog(LOG, "!!> AnyTablesyncInProgress?: Table relid %u is busy!", rstate->relid); found_busy = true; break; } @@ -1215,8 +1232,8 @@ AnyTablesyncInProgress() pgstat_report_stat(false); } - elog(DEBUG1, - "AnyTablesyncInProgress?: Scanned %d tables, and found busy = %s", + elog(LOG, + "!!> AnyTablesyncInProgress?: Scanned %d tables, and found busy = %s", count, found_busy ? "true" : "false"); @@ -1242,8 +1259,8 @@ BiggestTablesyncLSN() biggest_lsn = rstate->lsn; } - elog(DEBUG1, - "BiggestTablesyncLSN: Scanned %d tables. Biggest lsn found = %X/%X", + elog(LOG, + "!!> BiggestTablesyncLSN: Scanned %d tables. Biggest lsn found = %X/%X", count, LSN_FORMAT_ARGS(biggest_lsn)); diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c index 34e18a8..995222a 100644 --- a/src/backend/replication/logical/worker.c +++ b/src/backend/replication/logical/worker.c @@ -828,14 +828,16 @@ apply_handle_begin_prepare(StringInfo s) * Make sure every tablesync has reached at least SYNCDONE state * before letting the apply worker proceed. */ - elog(DEBUG1, - "apply_handle_begin_prepare, end_lsn = %X/%X, final_lsn = %X/%X, lstate_lsn = %X/%X", + elog(LOG, + "!!> apply_handle_begin_prepare, end_lsn = %X/%X, final_lsn = %X/%X, lstate_lsn = %X/%X", LSN_FORMAT_ARGS(begin_data.end_lsn), LSN_FORMAT_ARGS(begin_data.final_lsn), LSN_FORMAT_ARGS(MyLogicalRepWorker->relstate_lsn)); while (AnyTablesyncInProgress()) { + elog(LOG, "!!> apply_handle_begin_prepare - waiting for all sync workers to be DONE/READY"); + process_syncing_tables(begin_data.final_lsn); /* This latch is to prevent 100% CPU looping. */ @@ -853,7 +855,12 @@ apply_handle_begin_prepare(StringInfo s) * prepared) will be saved to a spoolfile for replay later at * commit_prepared time. */ - if (begin_data.final_lsn < BiggestTablesyncLSN()) + if (begin_data.final_lsn < BiggestTablesyncLSN() +#if 0 + || true /* XXX - Add this line to force psf (for + * easier debugging) */ +#endif + ) { char psfpath[MAXPGPATH]; @@ -895,6 +902,8 @@ apply_handle_prepare(StringInfo s) { PsfHashEntry *hentry; + elog(LOG, "!!> apply_handle_prepare: SPOOLING"); + /* Write the PREPARE info to the psf file. */ prepare_spoolfile_handler(LOGICAL_REP_MSG_PREPARE, s); @@ -916,6 +925,8 @@ apply_handle_prepare(StringInfo s) * removal on proc-exit just in case there is an unexpected restart * between now and when commit_prepared happens. */ + elog(LOG, + "!!> apply_handle_prepare: Make sure the spoolfile is not removed on proc-exit"); hentry = (PsfHashEntry *) hash_search(psf_hash, psf_cur.name, HASH_FIND, NULL); Assert(hentry); @@ -1000,6 +1011,8 @@ apply_handle_commit_prepared(StringInfo s) { int nchanges; + elog(LOG, "!!> apply_handle_commit_prepared: replaying the spooled messages"); + /* * Replay/dispatch the spooled messages. */ @@ -1007,8 +1020,8 @@ apply_handle_commit_prepared(StringInfo s) ensure_transaction(); nchanges = prepare_spoolfile_replay_messages(psfpath, prepare_data.prepare_lsn); - elog(DEBUG1, - "apply_handle_commit_prepared: replayed %d (all) changes.", + elog(LOG, + "!!> apply_handle_commit_prepared: replayed %d (all) changes.", nchanges); /* After replaying the psf it is no longer needed. Just delete it. */ @@ -1072,6 +1085,7 @@ apply_handle_rollback_prepared(StringInfo s) * Prepare Spoolfile (using_psf) because in that case there is no matching * PrepareTransactionBlock done yet. */ + elog(LOG, "!!> apply_handle_rollback_prepared: using_psf = %d", using_psf); if (!using_psf && LookupGXact(rollback_data.gid, rollback_data.prepare_end_lsn, rollback_data.preparetime)) @@ -2350,18 +2364,22 @@ apply_dispatch(StringInfo s) return; case LOGICAL_REP_MSG_BEGIN_PREPARE: + elog(LOG, "!!> ------ apply_handle_begin_prepare ------"); apply_handle_begin_prepare(s); return; case LOGICAL_REP_MSG_PREPARE: + elog(LOG, "!!> ------ apply_handle_prepare ------"); apply_handle_prepare(s); return; case LOGICAL_REP_MSG_COMMIT_PREPARED: + elog(LOG, "!!> ------ apply_handle_commit_prepared ------"); apply_handle_commit_prepared(s); return; case LOGICAL_REP_MSG_ROLLBACK_PREPARED: + elog(LOG, "!!> ------ apply_handle_rollback_prepared ------"); apply_handle_rollback_prepared(s); return; @@ -3555,8 +3573,8 @@ IsLogicalWorker(void) static bool prepare_spoolfile_handler(LogicalRepMsgType action, StringInfo s) { - elog(DEBUG1, - "prepare_spoolfile_handler for action '%c'. %s write to spool file", + elog(LOG, + "!!> prepare_spoolfile_handler for action '%c'. %s write to spool file", action, psf_cur.is_spooling ? "Do" : "Don't"); @@ -3580,7 +3598,7 @@ prepare_spoolfile_create(char *path) bool file_found; PsfHashEntry *hentry; - elog(DEBUG1, "creating file \"%s\" for prepare changes", path); + elog(LOG, "!!> creating file \"%s\" for prepare changes", path); Assert(!psf_cur.is_spooling); @@ -3589,7 +3607,7 @@ prepare_spoolfile_create(char *path) if (!file_found) { - elog(DEBUG1, "Not found file \"%s\". Create it.", path); + elog(LOG, "!!> Not found file \"%s\". Create it.", path); psf_cur.vfd = PathNameOpenFile(path, O_RDWR | O_CREAT | O_TRUNC | PG_BINARY); if (psf_cur.vfd < 0) ereport(ERROR, @@ -3602,7 +3620,7 @@ prepare_spoolfile_create(char *path) * Open the file and seek to the beginning because we always want to * create/overwrite this file. */ - elog(DEBUG1, "Found file \"%s\". Overwrite it.", path); + elog(LOG, "!!> Found file \"%s\". Overwrite it.", path); psf_cur.vfd = PathNameOpenFile(path, O_RDWR | O_CREAT | O_TRUNC | PG_BINARY); if (psf_cur.vfd < 0) ereport(ERROR, @@ -3630,6 +3648,7 @@ prepare_spoolfile_create(char *path) static void prepare_spoolfile_close() { + elog(LOG, "!!> prepare_spoolfile_close"); if (psf_cur.vfd >= 0) FileClose(psf_cur.vfd); @@ -3645,6 +3664,8 @@ prepare_spoolfile_close() static void prepare_spoolfile_delete(char *path) { + elog(LOG, "!!> prepare_spoolfile_delete: \"%s\"", path); + /* The current psf should be closed already, but make sure anyway. */ prepare_spoolfile_close(); @@ -3670,18 +3691,20 @@ prepare_spoolfile_write(char action, StringInfo s) Assert(psf_cur.is_spooling); - elog(DEBUG1, "prepare_spoolfile_write: writing action '%c'", action); + elog(LOG, "!!> prepare_spoolfile_write: writing action '%c'", action); /* total on-disk size, including the action type character */ len = (s->len - s->cursor) + sizeof(char); /* first write the size */ + elog(LOG, "!!> prepare_spoolfile_write: A writing len bytes = %d", len); bytes_written = FileWrite(psf_cur.vfd, (char *)&len, sizeof(len), psf_cur.cur_offset, WAIT_EVENT_DATA_FILE_WRITE); Assert(bytes_written == sizeof(len)); psf_cur.cur_offset += bytes_written; /* then the action */ + elog(LOG, "!!> prepare_spoolfile_write: B writing action = %c, %d bytes", action, (int)sizeof(action)); bytes_written = FileWrite(psf_cur.vfd, &action, sizeof(action), psf_cur.cur_offset, WAIT_EVENT_DATA_FILE_WRITE); Assert(bytes_written == sizeof(action)); @@ -3690,6 +3713,7 @@ prepare_spoolfile_write(char action, StringInfo s) /* and finally the remaining part of the buffer (after the XID) */ len = (s->len - s->cursor); + elog(LOG, "!!> prepare_spoolfile_write: C writing len bytes = %d", len); bytes_written = FileWrite(psf_cur.vfd, &s->data[s->cursor], len, psf_cur.cur_offset, WAIT_EVENT_DATA_FILE_WRITE); Assert(bytes_written == len); @@ -3710,6 +3734,11 @@ prepare_spoolfile_exists(char *path) if (fd >= 0) FileClose(fd); + elog(LOG, + "!!> prepare_spoolfile_exists: Prepared spoolfile \"%s\" was %s", + path, + found ? "found" : "not found"); + return found; } @@ -3726,8 +3755,8 @@ prepare_spoolfile_replay_messages(char *path, XLogRecPtr final_lsn) oldctx2; PsfFile psf = { .is_spooling = false, .vfd = -1, .cur_offset = 0 }; - elog(DEBUG1, - "prepare_spoolfile_replay_messages: replaying changes from file \"%s\"", + elog(LOG, + "!!> prepare_spoolfile_replay_messages: replaying changes from file \"%s\"", path); /* @@ -3772,6 +3801,7 @@ prepare_spoolfile_replay_messages(char *path, XLogRecPtr final_lsn) nbytes = FileRead(psf.vfd, (char *) &len, sizeof(len), psf.cur_offset, WAIT_EVENT_DATA_FILE_READ); psf.cur_offset += nbytes; + elog(LOG, "!!> prepare_spoolfile_replay_messages: nbytes = %d, len = %d", nbytes, len); /* have we reached end of the file? */ if (nbytes == 0) @@ -3790,6 +3820,7 @@ prepare_spoolfile_replay_messages(char *path, XLogRecPtr final_lsn) buffer = repalloc(buffer, len); /* and finally read the data into the buffer */ + elog(LOG, "!!> prepare_spoolfile_replay_messages: read %d bytes into buffer", len); nbytes = FileRead(psf.vfd, buffer, len, psf.cur_offset, WAIT_EVENT_DATA_FILE_READ); psf.cur_offset += nbytes; @@ -3806,7 +3837,9 @@ prepare_spoolfile_replay_messages(char *path, XLogRecPtr final_lsn) /* Ensure we are reading the data into our memory context. */ oldctx2 = MemoryContextSwitchTo(ApplyMessageContext); + elog(LOG, "!!> prepare_spoolfile_replay_messages: Before dispatch"); apply_dispatch(&s2); + elog(LOG, "!!> prepare_spoolfile_replay_messages: After dispatch"); MemoryContextReset(ApplyMessageContext); @@ -3815,13 +3848,13 @@ prepare_spoolfile_replay_messages(char *path, XLogRecPtr final_lsn) nchanges++; if (nchanges % 1000 == 0) - elog(DEBUG1, "replayed %d changes from file '%s'", + elog(LOG, "!!> replayed %d changes from file '%s'", nchanges, path); } FileClose(psf.vfd); - elog(DEBUG1, "replayed %d (all) changes from file \"%s\"", + elog(LOG, "!!> replayed %d (all) changes from file \"%s\"", nchanges, path); return nchanges; @@ -3857,6 +3890,8 @@ prepare_spoolfile_on_proc_exit(int status, Datum arg) HASH_SEQ_STATUS seq_status; PsfHashEntry *hentry; + elog(LOG, "!!> prepare_spoolfile_on_proc_exit"); + /* Iterate the HTAB looking for what file can be deleted. */ if (psf_hash) { @@ -3865,6 +3900,7 @@ prepare_spoolfile_on_proc_exit(int status, Datum arg) { char *path = hentry->name; + elog(LOG, "!!> prepare_spoolfile_proc_exit: found '%s'", path); if (hentry->allow_delete) prepare_spoolfile_delete(path); } -- 1.8.3.1