From 93f9518cabd904de7188823ffe1c8185737f80d3 Mon Sep 17 00:00:00 2001 From: Masahiko Sawada Date: Tue, 1 Aug 2023 17:18:58 +0900 Subject: [PATCH v2] Fix ReorderBufferCheckMemoryLimit() comment. Commit 7259736a6 updated the comment but it was not correct since ReorderBufferLargestStreamableTopTXN() retuns only top-level transactions. Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CAD21AoA9XB7OR86BqvrCe2dMYX%2BZv3-BvVmjF%3DGY2z6jN-kqjg%40mail.gmail.com Backpatch-through: 14 --- src/backend/replication/logical/reorderbuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 26d252bd87..87a4d2a24b 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -3602,8 +3602,8 @@ ReorderBufferCheckMemoryLimit(ReorderBuffer *rb) rb->size > 0)) { /* - * Pick the largest transaction (or subtransaction) and evict it from - * memory by streaming, if possible. Otherwise, spill to disk. + * Pick the largest transaction and evict it from memory by streaming, + * if possible. Otherwise, spill to disk. */ if (ReorderBufferCanStartStreaming(rb) && (txn = ReorderBufferLargestStreamableTopTXN(rb)) != NULL) -- 2.31.1