From 6d11a01bedaa1203a51424ffba8d6340bcb1a58a Mon Sep 17 00:00:00 2001 From: David Christensen Date: Tue, 12 Dec 2023 16:55:52 -0500 Subject: [PATCH v2 4/9] Make PageUsableSpace incorporate variable-sized limit --- src/backend/storage/page/bufpage.c | 2 +- src/include/storage/bufpage.h | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c index 9a302ddc30..d3aec3278d 100644 --- a/src/backend/storage/page/bufpage.c +++ b/src/backend/storage/page/bufpage.c @@ -26,7 +26,7 @@ /* GUC variable */ bool ignore_checksum_failure = false; - +int ReservedPageSize = 0; /* ---------------------------------------------------------------- * Page support functions * ---------------------------------------------------------------- diff --git a/src/include/storage/bufpage.h b/src/include/storage/bufpage.h index 3d36a74385..c414effae3 100644 --- a/src/include/storage/bufpage.h +++ b/src/include/storage/bufpage.h @@ -214,11 +214,16 @@ typedef PageHeaderData *PageHeader; #define SizeOfPageHeaderData (offsetof(PageHeaderData, pd_linp)) /* - * how much space is left after smgr's bookkeeping, etc + * how much space is left after smgr's bookkeeping, etc; should be MAXALIGN */ -#define PageUsableSpace (BLCKSZ - SizeOfPageHeaderData) -StaticAssertDecl(PageUsableSpace == MAXALIGN(PageUsableSpace), - "SizeOfPageHeaderData must be MAXALIGN'd"); +extern int ReservedPageSize; + +/* ignore page usable space */ +#define PageUsableSpaceMax (BLCKSZ - SizeOfPageHeaderData) +#define PageUsableSpace (BLCKSZ - SizeOfPageHeaderData - ReservedPageSize) +// TODO: add init check here, yo +/* StaticAssertDecl(PageUsableSpace == MAXALIGN(PageUsableSpace), */ +/* "SizeOfPageHeaderData must be MAXALIGN'd"); */ /* * PageIsEmpty -- 2.40.1