From 7af6f83b5d31491288ffa70a982fd339b402707f Mon Sep 17 00:00:00 2001 From: David Christensen Date: Tue, 12 Dec 2023 16:55:52 -0500 Subject: [PATCH v3 03/28] feature: Add ReservedPageSize variable We redefine PageUsableSpace to account for this variable, as well as introduce the PageUsableSpaceMax to reflect /just/ BLCKSZ - SizeOfPageHeaderData in the few call sites that care at this point. --- src/backend/storage/page/bufpage.c | 2 +- src/include/storage/bufpage.h | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c index be6f1f62d2..63fce5b588 100644 --- a/src/backend/storage/page/bufpage.c +++ b/src/backend/storage/page/bufpage.c @@ -26,7 +26,7 @@ /* GUC variable */ bool ignore_checksum_failure = false; - +int ReservedPageSize = 0; /* ---------------------------------------------------------------- * Page support functions * ---------------------------------------------------------------- diff --git a/src/include/storage/bufpage.h b/src/include/storage/bufpage.h index 5492a3682c..9b9c6167ef 100644 --- a/src/include/storage/bufpage.h +++ b/src/include/storage/bufpage.h @@ -214,11 +214,13 @@ typedef PageHeaderData *PageHeader; #define SizeOfPageHeaderData (offsetof(PageHeaderData, pd_linp)) /* - * how much space is left after smgr's bookkeeping, etc + * how much space is left after smgr's bookkeeping, etc; should be MAXALIGN */ -#define PageUsableSpace (BLCKSZ - SizeOfPageHeaderData) -StaticAssertDecl(PageUsableSpace == MAXALIGN(PageUsableSpace), - "SizeOfPageHeaderData must be MAXALIGN'd"); +extern int ReservedPageSize; + +/* ignore page usable space */ +#define PageUsableSpaceMax (BLCKSZ - SizeOfPageHeaderData) +#define PageUsableSpace (BLCKSZ - SizeOfPageHeaderData - ReservedPageSize) /* * PageIsEmpty @@ -316,7 +318,7 @@ PageSetPageSizeAndVersion(Page page, Size size, uint8 version) static inline uint16 PageGetUsablePageSize(Page page) { - return PageGetPageSize(page) - SizeOfPageHeaderData; + return PageGetPageSize(page) - SizeOfPageHeaderData - ReservedPageSize; } /* ---------------- -- 2.40.1