From 10089b4184ab4af9363864bda3f003bde3f89854 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: Fri, 2 Aug 2024 20:51:31 +0900
Subject: [PATCH v35 18/21] Enable commit records to handle fork removals

Currently, COMMIT/ABORT WAL records store relation locators that need
to be removed at commit. This patch adds support for handling these
removals on a per-fork basis. While the PREPARE record can store the
same information, it is not used.
---
 src/backend/access/rmgrdesc/xactdesc.c | 44 ++++++++++++++++++++++----
 src/backend/access/transam/twophase.c  | 14 +++++---
 src/backend/access/transam/xact.c      | 18 ++++++++---
 src/backend/storage/buffer/bufmgr.c    |  2 +-
 src/backend/storage/smgr/md.c          | 11 +++++--
 src/include/access/xact.h              |  7 ++--
 src/include/storage/md.h               |  3 +-
 7 files changed, 78 insertions(+), 21 deletions(-)

diff --git a/src/backend/access/rmgrdesc/xactdesc.c b/src/backend/access/rmgrdesc/xactdesc.c
index 08172df83fd..766a0ebcee1 100644
--- a/src/backend/access/rmgrdesc/xactdesc.c
+++ b/src/backend/access/rmgrdesc/xactdesc.c
@@ -82,6 +82,12 @@ ParseCommitRecord(uint8 info, xl_xact_commit *xlrec, xl_xact_parsed_commit *pars
 
 		data += MinSizeOfXactRelfileLocators;
 		data += xl_rellocators->nrels * sizeof(RelFileLocator);
+
+		if (parsed->xinfo & XACT_XINFO_HAS_RELFILEFORKS)
+		{
+			parsed->xforks = (ForkBitmap *)data;
+			data += xl_rellocators->nrels * sizeof(ForkBitmap);
+		}
 	}
 
 	if (parsed->xinfo & XACT_XINFO_HAS_DROPPED_STATS)
@@ -188,6 +194,12 @@ ParseAbortRecord(uint8 info, xl_xact_abort *xlrec, xl_xact_parsed_abort *parsed)
 
 		data += MinSizeOfXactRelfileLocators;
 		data += xl_rellocator->nrels * sizeof(RelFileLocator);
+
+		if (parsed->xinfo & XACT_XINFO_HAS_RELFILEFORKS)
+		{
+			parsed->xforks = (ForkBitmap *)data;
+			data += xl_rellocator->nrels * sizeof(ForkBitmap);
+		}
 	}
 
 	if (parsed->xinfo & XACT_XINFO_HAS_DROPPED_STATS)
@@ -262,6 +274,12 @@ ParsePrepareRecord(uint8 info, xl_xact_prepare *xlrec, xl_xact_parsed_prepare *p
 	parsed->xlocators = (RelFileLocator *) bufptr;
 	bufptr += MAXALIGN(xlrec->ncommitrels * sizeof(RelFileLocator));
 
+	if (xlrec->comhasforks)
+	{
+		parsed->xforks = (ForkBitmap *) bufptr;
+		bufptr += MAXALIGN(xlrec->ncommitrels * sizeof(ForkBitmap));
+	}
+
 	parsed->stats = (xl_xact_stats_item *) bufptr;
 	bufptr += MAXALIGN(xlrec->ncommitstats * sizeof(xl_xact_stats_item));
 
@@ -274,7 +292,7 @@ ParsePrepareRecord(uint8 info, xl_xact_prepare *xlrec, xl_xact_parsed_prepare *p
 
 static void
 xact_desc_relations(StringInfo buf, char *label, int nrels,
-					RelFileLocator *xlocators)
+					RelFileLocator *xlocators, ForkBitmap *xforks)
 {
 	int			i;
 
@@ -287,6 +305,19 @@ xact_desc_relations(StringInfo buf, char *label, int nrels,
 
 			appendStringInfo(buf, " %s", path);
 			pfree(path);
+
+			if (xforks)
+			{
+				char delim = ':';
+				for (int j = 0 ; j <= MAX_FORKNUM ; j++)
+				{
+					if (FORKBITMAP_ISSET(xforks[i], j))
+					{
+						appendStringInfo(buf, "%c%d", delim, j);
+						delim = ',';
+					}
+				}
+			}
 		}
 	}
 }
@@ -339,7 +370,8 @@ xact_desc_commit(StringInfo buf, uint8 info, xl_xact_commit *xlrec, RepOriginId
 
 	appendStringInfoString(buf, timestamptz_to_str(xlrec->xact_time));
 
-	xact_desc_relations(buf, "rels", parsed.nrels, parsed.xlocators);
+	xact_desc_relations(buf, "rels",
+						parsed.nrels, parsed.xlocators, parsed.xforks);
 	xact_desc_subxacts(buf, parsed.nsubxacts, parsed.subxacts);
 	xact_desc_stats(buf, "", parsed.nstats, parsed.stats);
 
@@ -375,7 +407,8 @@ xact_desc_abort(StringInfo buf, uint8 info, xl_xact_abort *xlrec, RepOriginId or
 
 	appendStringInfoString(buf, timestamptz_to_str(xlrec->xact_time));
 
-	xact_desc_relations(buf, "rels", parsed.nrels, parsed.xlocators);
+	xact_desc_relations(buf, "rels",
+						parsed.nrels, parsed.xlocators, parsed.xforks);
 	xact_desc_subxacts(buf, parsed.nsubxacts, parsed.subxacts);
 
 	if (parsed.xinfo & XACT_XINFO_HAS_ORIGIN)
@@ -399,9 +432,8 @@ xact_desc_prepare(StringInfo buf, uint8 info, xl_xact_prepare *xlrec, RepOriginI
 	appendStringInfo(buf, "gid %s: ", parsed.twophase_gid);
 	appendStringInfoString(buf, timestamptz_to_str(parsed.xact_time));
 
-	xact_desc_relations(buf, "rels(commit)", parsed.nrels, parsed.xlocators);
-	xact_desc_relations(buf, "rels(abort)", parsed.nabortrels,
-						parsed.abortlocators);
+	xact_desc_relations(buf, "rels(commit)", parsed.nrels,
+						parsed.xlocators, parsed.xforks);
 	xact_desc_stats(buf, "commit ", parsed.nstats, parsed.stats);
 	xact_desc_stats(buf, "abort ", parsed.nabortstats, parsed.abortstats);
 	xact_desc_subxacts(buf, parsed.nsubxacts, parsed.subxacts);
diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
index b4c423e449e..4def078b652 100644
--- a/src/backend/access/transam/twophase.c
+++ b/src/backend/access/transam/twophase.c
@@ -203,6 +203,7 @@ static void RecordTransactionCommitPrepared(TransactionId xid,
 											TransactionId *children,
 											int nrels,
 											RelFileLocator *rels,
+											ForkBitmap *forks,
 											int nstats,
 											xl_xact_stats_item *stats,
 											int ninvalmsgs,
@@ -1524,6 +1525,7 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
 	TransactionId latestXid;
 	TransactionId *children;
 	RelFileLocator *commitrels;
+	ForkBitmap	   *commitforks = NULL;
 	xl_xact_stats_item *commitstats;
 	xl_xact_stats_item *abortstats;
 	SharedInvalidationMessage *invalmsgs;
@@ -1582,7 +1584,8 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
 	if (isCommit)
 		RecordTransactionCommitPrepared(xid,
 										hdr->nsubxacts, children,
-										hdr->ncommitrels, commitrels,
+										hdr->ncommitrels,
+										commitrels, commitforks,
 										hdr->ncommitstats,
 										commitstats,
 										hdr->ninvalmsgs, invalmsgs,
@@ -1610,6 +1613,9 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
 	 */
 	gxact->valid = false;
 
+	/* Currently, prepare info should not have per-fork storage information. */
+	Assert(!commitforks);
+
 	/*
 	 * We have to remove any files that were supposed to be dropped. For
 	 * consistency with the regular xact.c code paths, must do this before
@@ -1622,7 +1628,7 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
 	if (isCommit)
 	{
 		/* Make sure files supposed to be dropped are dropped */
-		DropRelationFiles(commitrels, hdr->ncommitrels, false);
+		DropRelationFiles(commitrels, commitforks, hdr->ncommitrels, false);
 	}
 
 	if (isCommit)
@@ -2317,7 +2323,7 @@ RecordTransactionCommitPrepared(TransactionId xid,
 								int nchildren,
 								TransactionId *children,
 								int nrels,
-								RelFileLocator *rels,
+								RelFileLocator *rels, ForkBitmap *forks,
 								int nstats,
 								xl_xact_stats_item *stats,
 								int ninvalmsgs,
@@ -2348,7 +2354,7 @@ RecordTransactionCommitPrepared(TransactionId xid,
 	 * not they do.
 	 */
 	recptr = XactLogCommitRecord(committs,
-								 nchildren, children, nrels, rels,
+								 nchildren, children, nrels, rels, forks,
 								 nstats, stats,
 								 ninvalmsgs, invalmsgs,
 								 initfileinval,
diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
index c3302b4df46..c1acb41d24a 100644
--- a/src/backend/access/transam/xact.c
+++ b/src/backend/access/transam/xact.c
@@ -1326,6 +1326,7 @@ RecordTransactionCommit(void)
 	TransactionId latestXid = InvalidTransactionId;
 	int			nrels;
 	RelFileLocator *rels;
+	ForkBitmap	   *forks = NULL;
 	int			nchildren;
 	TransactionId *children;
 	int			ndroppedstats = 0;
@@ -1447,7 +1448,7 @@ RecordTransactionCommit(void)
 		 * Insert the commit XLOG record.
 		 */
 		XactLogCommitRecord(GetCurrentTransactionStopTimestamp(),
-							nchildren, children, nrels, rels,
+							nchildren, children, nrels, rels, forks,
 							ndroppedstats, droppedstats,
 							nmsgs, invalMessages,
 							RelcacheInitFileInval,
@@ -5850,7 +5851,7 @@ xactGetCommittedChildren(TransactionId **ptr)
 XLogRecPtr
 XactLogCommitRecord(TimestampTz commit_time,
 					int nsubxacts, TransactionId *subxacts,
-					int nrels, RelFileLocator *rels,
+					int nrels, RelFileLocator *rels, ForkBitmap *forks,
 					int ndroppedstats, xl_xact_stats_item *droppedstats,
 					int nmsgs, SharedInvalidationMessage *msgs,
 					bool relcacheInval,
@@ -5918,6 +5919,9 @@ XactLogCommitRecord(TimestampTz commit_time,
 		xl_xinfo.xinfo |= XACT_XINFO_HAS_RELFILELOCATORS;
 		xl_relfilelocators.nrels = nrels;
 		info |= XLR_SPECIAL_REL_UPDATE;
+
+		if (forks)
+			xl_xinfo.xinfo |= XACT_XINFO_HAS_RELFILEFORKS;
 	}
 
 	if (ndroppedstats > 0)
@@ -5980,6 +5984,10 @@ XactLogCommitRecord(TimestampTz commit_time,
 						 MinSizeOfXactRelfileLocators);
 		XLogRegisterData((char *) rels,
 						 nrels * sizeof(RelFileLocator));
+
+		if (xl_xinfo.xinfo & XACT_XINFO_HAS_RELFILEFORKS)
+			XLogRegisterData((char *) forks,
+							 nrels * sizeof(ForkBitmap));
 	}
 
 	if (xl_xinfo.xinfo & XACT_XINFO_HAS_DROPPED_STATS)
@@ -6256,7 +6264,8 @@ xact_redo_commit(xl_xact_parsed_commit *parsed,
 		XLogFlush(lsn);
 
 		/* Make sure files supposed to be dropped are dropped */
-		DropRelationFiles(parsed->xlocators, parsed->nrels, true);
+		DropRelationFiles(parsed->xlocators, parsed->xforks, parsed->nrels,
+						  true);
 	}
 
 	UndoLog_UndoByXid(true, xid, parsed->nsubxacts, parsed->subxacts, true);
@@ -6370,7 +6379,8 @@ xact_redo_abort(xl_xact_parsed_abort *parsed, TransactionId xid,
 		 */
 		XLogFlush(lsn);
 
-		DropRelationFiles(parsed->xlocators, parsed->nrels, true);
+		DropRelationFiles(parsed->xlocators, parsed->xforks, parsed->nrels,
+						  true);
 	}
 
 	UndoLog_UndoByXid(false, xid, parsed->nsubxacts, parsed->subxacts, true);
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 3e5ffd70c42..803a8fd2e6d 100644
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -160,7 +160,7 @@ static BufMgrCleanup * cleanups = NULL; /* head of linked list */
 typedef struct RelFileForks
 {
 	RelFileLocator rloc;	 /* key member for qsort */
-	ForkBitmap	   forks;	 /* fork number in bitmap */
+	ForkBitmap	   forks;	 /* fork numbers in bitmap */
 } RelFileForks;
 
 /* GUC variables */
diff --git a/src/backend/storage/smgr/md.c b/src/backend/storage/smgr/md.c
index 5cc02fdeeed..297a68d2bde 100644
--- a/src/backend/storage/smgr/md.c
+++ b/src/backend/storage/smgr/md.c
@@ -1464,7 +1464,8 @@ ForgetDatabaseSyncRequests(Oid dbid)
  * DropRelationFiles -- drop files of all given relations
  */
 void
-DropRelationFiles(RelFileLocator *delrels, int ndelrels, bool isRedo)
+DropRelationFiles(RelFileLocator *delrels, ForkBitmap *delforks, int ndelrels,
+				  bool isRedo)
 {
 	SMgrRelation *srels;
 	int			i;
@@ -1478,13 +1479,17 @@ DropRelationFiles(RelFileLocator *delrels, int ndelrels, bool isRedo)
 		{
 			ForkNumber	fork;
 
+			/* Close the spacified forks at smgr level. */
 			for (fork = 0; fork <= MAX_FORKNUM; fork++)
-				XLogDropRelation(delrels[i], fork);
+			{
+				if (!delforks || FORKBITMAP_ISSET(delforks[i], fork))
+					XLogDropRelation(delrels[i], fork);
+			}
 		}
 		srels[i] = srel;
 	}
 
-	smgrdounlinkall(srels, NULL, ndelrels, isRedo);
+	smgrdounlinkall(srels, delforks, ndelrels, isRedo);
 
 	for (i = 0; i < ndelrels; i++)
 		smgrclose(srels[i]);
diff --git a/src/include/access/xact.h b/src/include/access/xact.h
index 2e09566bdda..16d38c40052 100644
--- a/src/include/access/xact.h
+++ b/src/include/access/xact.h
@@ -196,6 +196,7 @@ typedef struct SavedTransactionCharacteristics
 #define XACT_XINFO_HAS_AE_LOCKS			(1U << 6)
 #define XACT_XINFO_HAS_GID				(1U << 7)
 #define XACT_XINFO_HAS_DROPPED_STATS	(1U << 8)
+#define XACT_XINFO_HAS_RELFILEFORKS		(1U << 9)
 
 /*
  * Also stored in xinfo, these indicating a variety of additional actions that
@@ -361,6 +362,7 @@ typedef struct xl_xact_prepare
 	Oid			owner;			/* user running the transaction */
 	int32		nsubxacts;		/* number of following subxact XIDs */
 	int32		ncommitrels;	/* number of delete-on-commit rels */
+	bool		comhasforks;	/* commitrels is accompanied by forknums */
 	int32		ncommitstats;	/* number of stats to drop on commit */
 	int32		nabortstats;	/* number of stats to drop on abort */
 	int32		ninvalmsgs;		/* number of cache invalidation messages */
@@ -388,6 +390,7 @@ typedef struct xl_xact_parsed_commit
 
 	int			nrels;
 	RelFileLocator *xlocators;
+	ForkBitmap	   *xforks;
 
 	int			nstats;
 	xl_xact_stats_item *stats;
@@ -397,8 +400,6 @@ typedef struct xl_xact_parsed_commit
 
 	TransactionId twophase_xid; /* only for 2PC */
 	char		twophase_gid[GIDSIZE];	/* only for 2PC */
-	int			nabortrels;		/* only for 2PC */
-	RelFileLocator *abortlocators;	/* only for 2PC */
 	int			nabortstats;	/* only for 2PC */
 	xl_xact_stats_item *abortstats; /* only for 2PC */
 
@@ -421,6 +422,7 @@ typedef struct xl_xact_parsed_abort
 
 	int			nrels;
 	RelFileLocator *xlocators;
+	ForkBitmap	   *xforks;
 
 	int			nstats;
 	xl_xact_stats_item *stats;
@@ -504,6 +506,7 @@ extern int	xactGetCommittedChildren(TransactionId **ptr);
 extern XLogRecPtr XactLogCommitRecord(TimestampTz commit_time,
 									  int nsubxacts, TransactionId *subxacts,
 									  int nrels, RelFileLocator *rels,
+									  ForkBitmap *forks,
 									  int ndroppedstats,
 									  xl_xact_stats_item *droppedstats,
 									  int nmsgs, SharedInvalidationMessage *msgs,
diff --git a/src/include/storage/md.h b/src/include/storage/md.h
index b72293c79a5..18dbf8a1462 100644
--- a/src/include/storage/md.h
+++ b/src/include/storage/md.h
@@ -48,7 +48,8 @@ extern void mdimmedsync(SMgrRelation reln, ForkNumber forknum);
 extern void mdregistersync(SMgrRelation reln, ForkNumber forknum);
 
 extern void ForgetDatabaseSyncRequests(Oid dbid);
-extern void DropRelationFiles(RelFileLocator *delrels, int ndelrels, bool isRedo);
+extern void DropRelationFiles(RelFileLocator *delrels, ForkBitmap *delforks,
+							  int ndelrels, bool isRedo);
 
 /* md sync callbacks */
 extern int	mdsyncfiletag(const FileTag *ftag, char *path);
-- 
2.43.5

