From 055a53481de4ae936c77baa84d8e21c50768458e Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: Fri, 16 Aug 2024 23:35:43 +0900
Subject: [PATCH v35 20/21] Allow init fork to be dropped

Building on features introduced in previous commits, this commit adds
the ability to drop init fork transactionally. Dropping an init fork
is deferred until transaction commit, using the pendingDeletes
mechanism. No user side code is provided.
---
 src/backend/catalog/storage.c | 50 ++++++++++++++++++++++++++++++++---
 src/include/catalog/storage.h |  1 +
 2 files changed, 47 insertions(+), 4 deletions(-)

diff --git a/src/backend/catalog/storage.c b/src/backend/catalog/storage.c
index 10ab5baf97a..f2dc413c738 100644
--- a/src/backend/catalog/storage.c
+++ b/src/backend/catalog/storage.c
@@ -178,6 +178,17 @@ void
 RelationCreateFork(SMgrRelation srel, ForkNumber forkNum,
 				   bool wal_log, bool undo_log)
 {
+#ifdef USE_ASSERT_CHECKING
+	/* we must not have pending delete for the init fork. */
+	if (forkNum == INIT_FORKNUM)
+	{
+		for (PendingRelDelete *p = pendingDeletes ; p != NULL ; p = p->next)
+			Assert(!FORKBITMAP_ISSET(p->forks, INIT_FORKNUM) ||
+				   !RelFileLocatorEquals(srel->smgr_rlocator.locator,
+										 p->rlocator));
+	}
+#endif
+
 	/* Schedule the removal of this init fork at abort if requested. */
 	if (undo_log)
 		ulog_smgrcreate(srel, forkNum);
@@ -189,6 +200,29 @@ RelationCreateFork(SMgrRelation srel, ForkNumber forkNum,
 	smgrcreate(srel, forkNum, false);
 }
 
+/*
+ * RelationDropInitFork
+ *		Delete physical storage for the init fork of a relation.
+ */
+void
+RelationDropInitFork(SMgrRelation srel)
+{
+	int 			nestLevel = GetCurrentTransactionNestLevel();
+	RelFileLocator	rlocator = srel->smgr_rlocator.locator;
+	ProcNumber		procNumber = srel->smgr_rlocator.backend;
+	PendingRelDelete *pending;
+
+	/* Schedule the removal of this init fork at commit. */
+	pending = (PendingRelDelete *)
+		MemoryContextAlloc(TopMemoryContext, sizeof(PendingRelDelete));
+	pending->rlocator = rlocator;
+	pending->procNumber = procNumber;
+	pending->forks = FORKBITMAP_BIT(INIT_FORKNUM);
+	pending->nestLevel = nestLevel;
+	pending->next = pendingDeletes;
+	pendingDeletes = pending;
+ }
+
 /*
  * Perform XLogInsert of an XLOG_SMGR_CREATE record to WAL.
  */
@@ -758,8 +792,6 @@ smgrDoPendingDeletes(bool isCommit)
 			{
 				SMgrRelation srel;
 
-				Assert(pending->forks == FORKBITMAP_ALLFORKS());
-
 				srel = smgropen(pending->rlocator, pending->procNumber);
 
 				/* allocate the initial array, or extend it, if needed */
@@ -1057,8 +1089,18 @@ AtSubCommit_smgr(void)
 
 	for (pending = pendingDeletes; pending != NULL; pending = pending->next)
 	{
-		if (pending->nestLevel >= nestLevel)
-			pending->nestLevel = nestLevel - 1;
+		if (pending->nestLevel < nestLevel)
+		{
+#ifdef USE_ASSERT_CHECKING
+			/* all the remaining entries must be of upper subtransactions */
+			for (; pending ; pending = pending->next)
+				Assert(pending->nestLevel < nestLevel);
+#endif
+			break;
+		}
+
+		/* move this entry to the immediately upper subtransaction */
+		pending->nestLevel = nestLevel - 1;
 	}
 }
 
diff --git a/src/include/catalog/storage.h b/src/include/catalog/storage.h
index a1abd614cdc..06a32c56a88 100644
--- a/src/include/catalog/storage.h
+++ b/src/include/catalog/storage.h
@@ -27,6 +27,7 @@ extern SMgrRelation RelationCreateStorage(RelFileLocator rlocator,
 										  bool register_delete);
 extern void RelationCreateFork(SMgrRelation srel, ForkNumber forkNum,
 							   bool wal_log, bool undo_log);
+extern void RelationDropInitFork(SMgrRelation srel);
 extern void RelationDropStorage(Relation rel);
 extern void RelationPreserveStorageOnCommit(RelFileLocator rlocator);
 extern void RelationPreTruncate(Relation rel);
-- 
2.43.5

