From 104f7c924cf461c7e31fba122cb2219da32edf08 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: Thu, 15 Aug 2024 11:26:01 +0900
Subject: [PATCH v36 12/17] Prepare for preventing DML operations on relations.

Performing data manipulation on relations with in-place persistence
changes can lead to unrecoverable issues, particularly with
indexes. To prevent potential data corruption, this update sets up
mechanisms to inhibit DML operations in these cases rather than
attempting to accommodate them. No user-side code included.
---
 src/backend/access/transam/xact.c  |  7 ++++++
 src/backend/executor/execMain.c    |  5 +++-
 src/backend/tcop/utility.c         | 18 ++++++++++++++
 src/backend/utils/cache/relcache.c | 39 +++++++++++++++++++++++++++---
 src/include/access/xact.h          |  2 ++
 src/include/miscadmin.h            |  1 +
 src/include/utils/rel.h            |  7 ++++++
 src/include/utils/relcache.h       |  1 +
 8 files changed, 76 insertions(+), 4 deletions(-)

diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
index ed73cda9acf..b609a783464 100644
--- a/src/backend/access/transam/xact.c
+++ b/src/backend/access/transam/xact.c
@@ -86,6 +86,12 @@ bool		XactDeferrable;
 
 int			synchronous_commit = SYNCHRONOUS_COMMIT_ON;
 
+/*
+ * Indicate whether relation persistence flipping was performed in the current
+ * transacion.
+ */
+bool	XactPersistenceChanged;
+
 /*
  * CheckXidAlive is a xid value pointing to a possibly ongoing (sub)
  * transaction.  Currently, it is used in logical decoding.  It's possible
@@ -2131,6 +2137,7 @@ StartTransaction(void)
 		s->startedInRecovery = false;
 		XactReadOnly = DefaultXactReadOnly;
 	}
+	XactPersistenceChanged = false;
 	XactDeferrable = DefaultXactDeferrable;
 	XactIsoLevel = DefaultXactIsoLevel;
 	forceSyncCommit = false;
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
index 1c12d6ebff0..c84acc048ce 100644
--- a/src/backend/executor/execMain.c
+++ b/src/backend/executor/execMain.c
@@ -162,7 +162,7 @@ standard_ExecutorStart(QueryDesc *queryDesc, int eflags)
 	 * against performing unsafe operations in parallel mode, but this gives a
 	 * more user-friendly error message.
 	 */
-	if ((XactReadOnly || IsInParallelMode()) &&
+	if ((XactReadOnly || XactPersistenceChanged || IsInParallelMode()) &&
 		!(eflags & EXEC_FLAG_EXPLAIN_ONLY))
 		ExecCheckXactReadOnly(queryDesc->plannedstmt);
 
@@ -815,6 +815,9 @@ ExecCheckXactReadOnly(PlannedStmt *plannedstmt)
 			continue;
 
 		PreventCommandIfReadOnly(CreateCommandName((Node *) plannedstmt));
+
+		PreventCommandIfPersistenceChanged(
+			CreateCommandName((Node *) plannedstmt), perminfo->relid);
 	}
 
 	if (plannedstmt->commandType != CMD_SELECT || plannedstmt->hasModifyingCTE)
diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c
index c2ed8214ef6..ce2f259fa0c 100644
--- a/src/backend/tcop/utility.c
+++ b/src/backend/tcop/utility.c
@@ -411,6 +411,24 @@ PreventCommandIfReadOnly(const char *cmdname)
 						cmdname)));
 }
 
+/*
+ * PreventCommandIfPersistenceChanged: throw error if persistence changed was
+ * 		performed
+ */
+void
+PreventCommandIfPersistenceChanged(const char *cmdname, Oid relid)
+{
+	Relation rel;
+
+	rel = RelationIdGetRelation(relid);
+	if (rel->rd_firstPersistenceChangeSubid != InvalidSubTransactionId)
+		ereport(ERROR,
+				errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+				errmsg("cannot execute %s on relation \"%s\" because of its persistence change in the current transaction",
+					   cmdname, get_rel_name(relid)));
+	RelationClose(rel);
+}
+
 /*
  * PreventCommandIfParallelMode: throw error if current (sub)transaction is
  * in parallel mode.
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 46a5ddfb3ae..f3a0d0b13d2 100644
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -1125,6 +1125,7 @@ retry:
 	relation->rd_createSubid = InvalidSubTransactionId;
 	relation->rd_newRelfilelocatorSubid = InvalidSubTransactionId;
 	relation->rd_firstRelfilelocatorSubid = InvalidSubTransactionId;
+	relation->rd_firstPersistenceChangeSubid = InvalidSubTransactionId;
 	relation->rd_droppedSubid = InvalidSubTransactionId;
 	switch (relation->rd_rel->relpersistence)
 	{
@@ -1888,6 +1889,7 @@ formrdesc(const char *relationName, Oid relationReltype,
 	relation->rd_createSubid = InvalidSubTransactionId;
 	relation->rd_newRelfilelocatorSubid = InvalidSubTransactionId;
 	relation->rd_firstRelfilelocatorSubid = InvalidSubTransactionId;
+	relation->rd_firstPersistenceChangeSubid = InvalidSubTransactionId;
 	relation->rd_droppedSubid = InvalidSubTransactionId;
 	relation->rd_backend = INVALID_PROC_NUMBER;
 	relation->rd_islocaltemp = false;
@@ -2691,6 +2693,7 @@ RelationRebuildRelation(Relation relation)
 		SWAPFIELD(SubTransactionId, rd_createSubid);
 		SWAPFIELD(SubTransactionId, rd_newRelfilelocatorSubid);
 		SWAPFIELD(SubTransactionId, rd_firstRelfilelocatorSubid);
+		SWAPFIELD(SubTransactionId, rd_firstPersistenceChangeSubid);
 		SWAPFIELD(SubTransactionId, rd_droppedSubid);
 		/* un-swap rd_rel pointers, swap contents instead */
 		SWAPFIELD(Form_pg_class, rd_rel);
@@ -2780,7 +2783,8 @@ static void
 RelationFlushRelation(Relation relation)
 {
 	if (relation->rd_createSubid != InvalidSubTransactionId ||
-		relation->rd_firstRelfilelocatorSubid != InvalidSubTransactionId)
+		relation->rd_firstRelfilelocatorSubid != InvalidSubTransactionId ||
+		relation->rd_firstPersistenceChangeSubid != InvalidSubTransactionId)
 	{
 		/*
 		 * New relcache entries are always rebuilt, not flushed; else we'd
@@ -2857,7 +2861,8 @@ RelationForgetRelation(Oid rid)
 
 	Assert(relation->rd_droppedSubid == InvalidSubTransactionId);
 	if (relation->rd_createSubid != InvalidSubTransactionId ||
-		relation->rd_firstRelfilelocatorSubid != InvalidSubTransactionId)
+		relation->rd_firstRelfilelocatorSubid != InvalidSubTransactionId ||
+		relation->rd_firstPersistenceChangeSubid != InvalidSubTransactionId)
 	{
 		/*
 		 * In the event of subtransaction rollback, we must not forget
@@ -2973,7 +2978,8 @@ RelationCacheInvalidate(bool debug_discard)
 		 * applicable pending invalidations.
 		 */
 		if (relation->rd_createSubid != InvalidSubTransactionId ||
-			relation->rd_firstRelfilelocatorSubid != InvalidSubTransactionId)
+			relation->rd_firstRelfilelocatorSubid != InvalidSubTransactionId ||
+			relation->rd_firstPersistenceChangeSubid != InvalidSubTransactionId)
 			continue;
 
 		relcacheInvalsReceived++;
@@ -3295,6 +3301,7 @@ AtEOXact_cleanup(Relation relation, bool isCommit)
 	relation->rd_createSubid = InvalidSubTransactionId;
 	relation->rd_newRelfilelocatorSubid = InvalidSubTransactionId;
 	relation->rd_firstRelfilelocatorSubid = InvalidSubTransactionId;
+	relation->rd_firstPersistenceChangeSubid = InvalidSubTransactionId;
 	relation->rd_droppedSubid = InvalidSubTransactionId;
 
 	if (clear_relcache)
@@ -3410,6 +3417,7 @@ AtEOSubXact_cleanup(Relation relation, bool isCommit,
 			relation->rd_createSubid = InvalidSubTransactionId;
 			relation->rd_newRelfilelocatorSubid = InvalidSubTransactionId;
 			relation->rd_firstRelfilelocatorSubid = InvalidSubTransactionId;
+			relation->rd_firstPersistenceChangeSubid = InvalidSubTransactionId;
 			relation->rd_droppedSubid = InvalidSubTransactionId;
 			RelationClearRelation(relation);
 			return;
@@ -3456,6 +3464,14 @@ AtEOSubXact_cleanup(Relation relation, bool isCommit,
 		else
 			relation->rd_droppedSubid = InvalidSubTransactionId;
 	}
+
+	if (relation->rd_firstPersistenceChangeSubid == mySubid)
+	{
+		if (isCommit)
+			relation->rd_firstPersistenceChangeSubid = parentSubid;
+		else
+			relation->rd_firstPersistenceChangeSubid = InvalidSubTransactionId;
+	}
 }
 
 
@@ -3546,6 +3562,7 @@ RelationBuildLocalRelation(const char *relname,
 	rel->rd_createSubid = GetCurrentSubTransactionId();
 	rel->rd_newRelfilelocatorSubid = InvalidSubTransactionId;
 	rel->rd_firstRelfilelocatorSubid = InvalidSubTransactionId;
+	rel->rd_firstPersistenceChangeSubid = InvalidSubTransactionId;
 	rel->rd_droppedSubid = InvalidSubTransactionId;
 
 	/*
@@ -3927,6 +3944,21 @@ RelationAssumeNewRelfilelocator(Relation relation)
 	EOXactListAdd(relation);
 }
 
+/*
+ * RelationAssumePersistenceChange
+ *
+ * Code that changes relation persistence must call this.  This call triggers
+ * abort-time cleanups and prevents further data manipulation on the relation.
+ */
+void
+RelationAssumePersistenceChange(Relation relation)
+{
+	XactPersistenceChanged = true;
+	relation->rd_firstPersistenceChangeSubid = GetCurrentSubTransactionId();
+
+	/* Flag relation as needing eoxact cleanup (to clear this field) */
+	EOXactListAdd(relation);
+}
 
 /*
  *		RelationCacheInitialize
@@ -6413,6 +6445,7 @@ load_relcache_init_file(bool shared)
 		rel->rd_createSubid = InvalidSubTransactionId;
 		rel->rd_newRelfilelocatorSubid = InvalidSubTransactionId;
 		rel->rd_firstRelfilelocatorSubid = InvalidSubTransactionId;
+		rel->rd_firstPersistenceChangeSubid = InvalidSubTransactionId;
 		rel->rd_droppedSubid = InvalidSubTransactionId;
 		rel->rd_amcache = NULL;
 		rel->pgstat_info = NULL;
diff --git a/src/include/access/xact.h b/src/include/access/xact.h
index a5b61eec8f3..a3c470d7e7a 100644
--- a/src/include/access/xact.h
+++ b/src/include/access/xact.h
@@ -55,6 +55,8 @@ extern PGDLLIMPORT int XactIsoLevel;
 extern PGDLLIMPORT bool DefaultXactReadOnly;
 extern PGDLLIMPORT bool XactReadOnly;
 
+extern PGDLLIMPORT bool XactPersistenceChanged;
+
 /* flag for logging statements in this transaction */
 extern PGDLLIMPORT bool xact_is_sampled;
 
diff --git a/src/include/miscadmin.h b/src/include/miscadmin.h
index 3f97fcef800..69cc5adfa6c 100644
--- a/src/include/miscadmin.h
+++ b/src/include/miscadmin.h
@@ -307,6 +307,7 @@ extern long get_stack_depth_rlimit(void);
 extern void PreventCommandIfReadOnly(const char *cmdname);
 extern void PreventCommandIfParallelMode(const char *cmdname);
 extern void PreventCommandDuringRecovery(const char *cmdname);
+extern void PreventCommandIfPersistenceChanged(const char *cmdname, Oid relid);
 
 /*****************************************************************************
  *	  pdir.h --																 *
diff --git a/src/include/utils/rel.h b/src/include/utils/rel.h
index 87002049538..a361e910509 100644
--- a/src/include/utils/rel.h
+++ b/src/include/utils/rel.h
@@ -108,6 +108,13 @@ typedef struct RelationData
 													 * any value */
 	SubTransactionId rd_droppedSubid;	/* dropped with another Subid set */
 
+	/*
+	 * rd_firstPersistenceChangeSubid is the ID of the highest subtransaction
+	 * ID the rel's persistence change has survived into.
+	 */
+	SubTransactionId rd_firstPersistenceChangeSubid; /* highest subxact chaging
+													  * persistence */
+
 	Form_pg_class rd_rel;		/* RELATION tuple */
 	TupleDesc	rd_att;			/* tuple descriptor */
 	Oid			rd_id;			/* relation's object id */
diff --git a/src/include/utils/relcache.h b/src/include/utils/relcache.h
index 8d23959e95e..d1903e7a58c 100644
--- a/src/include/utils/relcache.h
+++ b/src/include/utils/relcache.h
@@ -119,6 +119,7 @@ extern Relation RelationBuildLocalRelation(const char *relname,
  */
 extern void RelationSetNewRelfilenumber(Relation relation, char persistence);
 extern void RelationAssumeNewRelfilelocator(Relation relation);
+extern void RelationAssumePersistenceChange(Relation relation);
 
 /*
  * Routines for flushing/rebuilding relcache entries in various scenarios
-- 
2.43.5

