From b0379016f49b126b9733f3955a48fc7997655c40 Mon Sep 17 00:00:00 2001 From: David Rowley Date: Sun, 20 Mar 2016 15:17:28 +1300 Subject: [PATCH 4/6] Add sanity regression tests for new aggregate serialize code. This goes to ensure that the standard set of aggregates match the same rules as is enforced by CREATE AGGREGATE --- src/test/regress/expected/opr_sanity.out | 50 ++++++++++++++++++++++++++++++++ src/test/regress/sql/opr_sanity.sql | 34 ++++++++++++++++++++++ 2 files changed, 84 insertions(+) diff --git a/src/test/regress/expected/opr_sanity.out b/src/test/regress/expected/opr_sanity.out index 7c09fa3..589b31d 100644 --- a/src/test/regress/expected/opr_sanity.out +++ b/src/test/regress/expected/opr_sanity.out @@ -1528,6 +1528,56 @@ WHERE proisagg AND provariadic != 0 AND a.aggkind = 'n'; -----+--------- (0 rows) +-- Check that all serial functions have a return type the same as the serial +-- type. +SELECT a.aggserialfn,a.aggserialtype,p.prorettype +FROM pg_aggregate a +INNER JOIN pg_proc p ON a.aggserialfn = p.oid +WHERE a.aggserialtype <> p.prorettype; + aggserialfn | aggserialtype | prorettype +-------------+---------------+------------ +(0 rows) + +-- Check that all the deserial functions have the same input type as the +-- serialtype +SELECT a.aggserialfn,a.aggserialtype,p.proargtypes[0] +FROM pg_aggregate a +INNER JOIN pg_proc p ON a.aggdeserialfn = p.oid +WHERE p.proargtypes[0] <> a.aggserialtype; + aggserialfn | aggserialtype | proargtypes +-------------+---------------+------------- +(0 rows) + +-- Check that the deserial function's input type is the same as the return type +-- of the serial function. +SELECT a.aggserialfn,a.aggserialtype,p1.proargtypes[0],p2.prorettype +FROM pg_aggregate a +INNER JOIN pg_proc p1 ON a.aggdeserialfn = p1.oid +INNER JOIN pg_proc p2 ON a.aggserialfn = p2.oid +WHERE p1.proargtypes[0] <> p2.prorettype; + aggserialfn | aggserialtype | proargtypes | prorettype +-------------+---------------+-------------+------------ +(0 rows) + +-- An aggregate should either have a complete set of serialtype, serial func +-- and deserial func, or none of them. +SELECT aggserialtype,aggserialfn,aggdeserialfn +FROM pg_aggregate +WHERE (aggserialtype <> 0 OR aggserialfn <> 0 OR aggdeserialfn <> 0) + AND (aggserialtype = 0 OR aggserialfn = 0 OR aggdeserialfn = 0); + aggserialtype | aggserialfn | aggdeserialfn +---------------+-------------+--------------- +(0 rows) + +-- Check that all aggregates with serialtypes have internal states. +-- (There's no point in serializing anything apart from internal) +SELECT aggfnoid,aggserialtype,aggtranstype +FROM pg_aggregate +WHERE aggserialtype <> 0 AND aggtranstype <> 'internal'::regtype; + aggfnoid | aggserialtype | aggtranstype +----------+---------------+-------------- +(0 rows) + -- **************** pg_opfamily **************** -- Look for illegal values in pg_opfamily fields SELECT p1.oid diff --git a/src/test/regress/sql/opr_sanity.sql b/src/test/regress/sql/opr_sanity.sql index 6c9784a..9da3599 100644 --- a/src/test/regress/sql/opr_sanity.sql +++ b/src/test/regress/sql/opr_sanity.sql @@ -1002,6 +1002,40 @@ SELECT p.oid, proname FROM pg_proc AS p JOIN pg_aggregate AS a ON a.aggfnoid = p.oid WHERE proisagg AND provariadic != 0 AND a.aggkind = 'n'; +-- Check that all serial functions have a return type the same as the serial +-- type. +SELECT a.aggserialfn,a.aggserialtype,p.prorettype +FROM pg_aggregate a +INNER JOIN pg_proc p ON a.aggserialfn = p.oid +WHERE a.aggserialtype <> p.prorettype; + +-- Check that all the deserial functions have the same input type as the +-- serialtype +SELECT a.aggserialfn,a.aggserialtype,p.proargtypes[0] +FROM pg_aggregate a +INNER JOIN pg_proc p ON a.aggdeserialfn = p.oid +WHERE p.proargtypes[0] <> a.aggserialtype; + +-- Check that the deserial function's input type is the same as the return type +-- of the serial function. +SELECT a.aggserialfn,a.aggserialtype,p1.proargtypes[0],p2.prorettype +FROM pg_aggregate a +INNER JOIN pg_proc p1 ON a.aggdeserialfn = p1.oid +INNER JOIN pg_proc p2 ON a.aggserialfn = p2.oid +WHERE p1.proargtypes[0] <> p2.prorettype; + +-- An aggregate should either have a complete set of serialtype, serial func +-- and deserial func, or none of them. +SELECT aggserialtype,aggserialfn,aggdeserialfn +FROM pg_aggregate +WHERE (aggserialtype <> 0 OR aggserialfn <> 0 OR aggdeserialfn <> 0) + AND (aggserialtype = 0 OR aggserialfn = 0 OR aggdeserialfn = 0); + +-- Check that all aggregates with serialtypes have internal states. +-- (There's no point in serializing anything apart from internal) +SELECT aggfnoid,aggserialtype,aggtranstype +FROM pg_aggregate +WHERE aggserialtype <> 0 AND aggtranstype <> 'internal'::regtype; -- **************** pg_opfamily **************** -- 1.9.5.msysgit.1