| From: | Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Subject: | Re: pg_plan_advice: fix empty FOREIGN_JOIN sublist validation |
| Date: | 2026-08-20 15:02:45 |
| Message-ID: | 178723816589.1145.6372890389262859808.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hello,
I have reviewed this patch and it looks good to me.
I can reproduce the issue in master branch and applying the patch in a specific branch has fixed the issue: new test case looks also good to me.
I don't think it is needed to check SQL compliance or to update documentation.
Regards
Pierre Forstmann.
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2026-08-20 15:56:43 | RE: Logical replication row filter loses unchanged toasted columns |
| Previous Message | Jan Nidzwetzki | 2026-08-20 13:31:53 | Re: Enable partitionwise join for partition keys wrapped by RelabelType |