| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: renaming ExecStoreWhateverTuple |
| Date: | 2019-03-25 16:36:56 |
| Message-ID: | 20190325163656.d3jcw45gg4sk7ypn@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-03-25 12:33:38 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > Maybe we don't really need the word "tuple". Like we could just make
> > it slot_store_heap() or SlotStoreHeap(). A slot can only store a
> > tuple, after all.
>
> I don't think it's wise to think of these things as just "slots";
> that name is way too generic. They are "tuple slots", and so that
> word has to stay in the relevant function names.
Hm. But we already have slot_{getsomeattrs, getallattrs, attisnull,
getattr, getsysattr}. But perhaps the att in there is enough addiitional
information?
Although now I'm looking at consistency annoyed at slot_attisnull (no r)
and slot_getattr (r) ;)
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-03-25 16:45:36 | Re: renaming ExecStoreWhateverTuple |
| Previous Message | Tom Lane | 2019-03-25 16:33:38 | Re: renaming ExecStoreWhateverTuple |