| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Inconsistent GUC descriptions |
| Date: | 2025-02-20 05:08:39 |
| Message-ID: | 20250220.140839.1444694904721968348.horikyota.ntt@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, (this mail is not a duplicate sent by mistake.)
The recent commit ac0e33136ab introduced the following message:
+ GUC_check_errdetail("The value of \"%s\" must be set to 0 during binary upgrade mode.",
However, the existing message for the same situation is written
without "The value of" at the beginning. In addition, all existing
messages following the "%s must be set to" pattern omit this phrase.
Therefore, I believe the initial part of the new message should be
removed for consistency. The attached patch makes this adjustment.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Align-a-recently-added-message-with-an-existing-one.patch | text/x-patch | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-02-20 05:37:18 | Re: Remove wal_[sync|write][_time] from pg_stat_wal and track_wal_io_timing |
| Previous Message | jian he | 2025-02-20 04:57:38 | Re: Virtual generated columns |