Re: BUG #19393: pg_upgrade fails with duplicate key violation when CHECK constraint named *_not_null exists

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: huseyin(dot)d3r(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19393: pg_upgrade fails with duplicate key violation when CHECK constraint named *_not_null exists
Date: 2026-02-21 13:45:31
Message-ID: 202602211203.n22ngw4ys4dj@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2026-Feb-21, Álvaro Herrera wrote:
>
> 1. this will cause an ABI break report for AddRelationNotNullConstraints
> in branch 18. I considered the idea of adding a shim function
> preserving the original API, but I think this is not a function likely
> to be used by third-party code. So I'll address this by adding an entry
> to .abi-compliance-history instead.

As expected, crake reported:

Leaf changes summary: 1 artifact changed
Changed leaf types summary: 0 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 1 Changed, 0 Added function (13 filtered out)
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added variable

1 function with incompatible sub-type changes:

[C] 'function List* AddRelationNotNullConstraints(Relation, List*, List*)' has some sub-type changes:
parameter 4 of type 'List*' was added

I have pushed the update to .abi-compliance-history, and crake is now green.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Cómo ponemos nuestros dedos en la arcilla del otro. Eso es la amistad; jugar
al alfarero y ver qué formas se pueden sacar del otro" (C. Halloway en
La Feria de las Tinieblas, R. Bradbury)

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message David G. Johnston 2026-02-21 15:05:06 Re: BUG: SUBSTRING on TOASTed text returns "invalid byte sequence for encoding UTF8: 0xc3"
Previous Message Álvaro Herrera 2026-02-21 11:56:24 Re: BUG #19393: pg_upgrade fails with duplicate key violation when CHECK constraint named *_not_null exists

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2026-02-21 13:49:58 Re: Incremental View Maintenance, take 2
Previous Message Álvaro Herrera 2026-02-21 11:56:24 Re: BUG #19393: pg_upgrade fails with duplicate key violation when CHECK constraint named *_not_null exists