Re: [PATCH] Add hint to wal_level errors for replication slots and pg_log_standby_snapshot

From: Joao Rito <joaovictor(dot)rito(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Zhijie Hou <houzhijie22(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add hint to wal_level errors for replication slots and pg_log_standby_snapshot
Date: 2026-11-19 03:26:57
Message-ID: 20261119032657.2429-1-joaovictor.rito@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Chao, Zhijie,

Thank you both for the feedback.

Zhijie, that is a fair point. The primary messages already state the required setting and value, so the hint repeats it. Chao, thank you for the shorter wording and the note about two spaces between sentences.

Unless someone thinks the hint is useful, I will drop this patch. If somebody prefers to keep it, I will send a new version with Chao's wording:

errhint("Set \"wal_level\" to \"replica\" or higher and restart the server.")

Thanks again,
Joao Rito

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Joao Rito 2026-11-19 03:26:53 Re: [PATCH] pg_upgrade: add hints to wal_level and max_replication_slots checks