| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Tristan Partin" <tristan(at)partin(dot)io> |
| Cc: | "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Macro redefinition warning after aeb07c55fab5c17a600b77ffcdc3b71425d6a8e7 |
| Date: | 2026-07-01 17:32:57 |
| Message-ID: | 3526243.1782927177@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Tristan Partin" <tristan(at)partin(dot)io> writes:
> When compiling, I get the following warnings:
> [338/2397] Compiling C object src/timezone/zic.p/zic.c.o
> In file included from ../src/timezone/zic.c:22:
> ../src/timezone/private.h:187:9: warning: ‘unreachable’ redefined
> 187 | #define unreachable() pg_unreachable()
> | ^~~~~~~~~~~
Thanks for the report.
> The upstream code for private.h's definition of unreachable() looks
> quite a bit different than ours[0].
Yeah. I intentionally used our version rather than hoping that
theirs would work in our environment. I still think that's the
right way, so I'm inclined to fix this by throwing in an "#undef".
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2026-07-01 17:51:25 | Add malloc attribute to memory allocation functions |
| Previous Message | Masahiko Sawada | 2026-07-01 17:30:30 | Re: Macro redefinition warning after aeb07c55fab5c17a600b77ffcdc3b71425d6a8e7 |