Re:Propose: Adding a '--enable-failover' option to 'pg_createsubscriber'

From: 高雪玉 <gaoxueyu_hope(at)163(dot)com>
To: "Ioseph Kim" <pgsql-kr(at)postgresql(dot)kr>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re:Propose: Adding a '--enable-failover' option to 'pg_createsubscriber'
Date: 2025-12-10 10:11:46
Message-ID: 4691855d.9719.19b07beda44.Coremail.gaoxueyu_hope@163.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
I have one comment to following comment:

pg_createsubscriber.c, the comment is not correct as this new option is not related with logical replication slot.
bool failover; /* enable failover option of logical replication slot */

Suggest to change to:
/* enable failover option of subscription */

Thanks,
Xueyu Gao
HighGo Software Co., Ltd.
https://www.highgo.com/

At 2025-12-10 17:03:48, "Ioseph Kim" <pgsql-kr(at)postgresql(dot)kr> wrote:
>Hi
>
>A failover option has been added to the CREATE SUBSCRITION command, but this functionality isn't easily accessible using the pg_createsubscriber tool.
>
>Subscriptions created using pg_createsubscriber must be configured for failover via an alter operation.
>
>To address this issue, we've added a simple --enable-failover option to the pg_createsubscriber tool.
>
>This patch is simple. It doesn't handle exceptions or provide any TAP test code.
>
>Please review this and we hope the development team will refine it further.
>
>ioseph

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2025-12-10 10:20:14 Re: Add a greedy join search algorithm to handle large join problems
Previous Message shveta malik 2025-12-10 10:07:35 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart