Re: Proposal: adding --enable-shadows-warning

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: adding --enable-shadows-warning
Date: 2025-11-28 09:20:51
Message-ID: 4782EEA1-0A8F-45AC-AA09-387E9DD3BA71@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 28 Nov 2025, at 10:02, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:

> To make hacker’s life easier, it would make sense to always enable “-Wshadow”, however, that may have a risk of breaking some compilers. So thinking over, I just fell adding an opt-in “—enable-shadows-warnings” could be a solution.

I'm not sure that adding buildsystem flags for compiler behaviour is the right
direction, isn't the environment variables like CFLAGS already covering this?

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rahila Syed 2025-11-28 09:22:14 Re: Enhancing Memory Context Statistics Reporting
Previous Message Bernice Southey 2025-11-28 09:20:32 Re: Second RewriteQuery complains about first RewriteQuery in edge case