Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.
Date: 2014-07-29 14:27:19
Message-ID: 53D7AF47.5020806@vmware.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 07/29/2014 05:10 PM, Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
>> Treat 2PC commit/abort the same as regular xacts in recovery.
>
> Looking at this again ... didn't you just break recoveryStopsBefore?
> ISTM the added line
>
> if (record_info == XLOG_XACT_COMMIT_PREPARED)
>
> needs to be
>
> else if (record_info == XLOG_XACT_COMMIT_PREPARED)
>
> As it stands, control will reach the "return false" for regular
> commit records.

Oops :-(. Fixed, thanks!

- Heikki

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2014-07-29 19:44:42 pgsql: Simplify multixact freezing a bit
Previous Message Heikki Linnakangas 2014-07-29 14:27:11 pgsql: Oops, fix recoveryStopsBefore functions for regular commits.