Re: pg_rewind: Doc update for PostgreSQL 18

From: Jesper Pedersen <jesperpedersen(dot)db(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: pg_rewind: Doc update for PostgreSQL 18
Date: 2025-06-09 19:48:49
Message-ID: 92de9ff7-274a-401f-ba53-1c9ae6f1b4ed@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Nathan,

On 6/9/25 3:15 PM, Nathan Bossart wrote:
>> + the cluster was initialized with <application>initdb</application>. Data checksums
>> + are enabled by default starting from PostgreSQL 18. <xref linkend="guc-full-page-writes"/>
>> must also be set to <literal>on</literal>, but is enabled by default.
>
> +1 for fixing this, but I'd like to bikeshed on the wording a bit. I think
> the above proposal loses information since it doesn't mention that
> wal_log_hints is off by default. But it might be tricky to work in all
> those details in a readable fashion. How about we change it to something
> like this:
>
> pg_rewind requires that the target server has full_page_writes enabled
> and at least one of either wal_log_hints or data checksums (see Section
> 28.2) enabled. full_page_writes and data checksums are enabled by
> default, but wal_log_hints is not.
>

Yeah, that is good.

> I think we ordinarily try to avoid too many version notes in the docs, and
> I see that initdb makes no mention of the fact that the default for data
> checksums changed in v18, so my first instinct is to leave that out.

Yes, we can leave the "18" part out since the documentation won't be
back-ported.

As to initdb it should probably mention data checksums due to
--no-data-checksums.

Feel free to commit your wording.

Thanks !

Best regards,
Jesper

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-06-09 19:55:43 Re: Question on error code selection in conflict detection
Previous Message Masahiko Sawada 2025-06-09 19:29:31 Re: Batch TIDs lookup in ambulkdelete