RE: SIGSEGV, FPE fix in pg_controldata

From: Ilyasov Ian <ianilyasov(at)outlook(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: SIGSEGV, FPE fix in pg_controldata
Date: 2025-02-04 16:36:02
Message-ID: AM0PR08MB36677978CDDD79F5469A7B98CDF42@AM0PR08MB3667.eurprd08.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for your answer, Alexander!
I like your patch and it looks similar to my first version of it before I came up to the possible segment size problem.

>Also, I don't think we should change
segment size to uint32 as it's already defined as int in awfully a lot
of places

I agree that changing segment size type is probably out of this thread and problem scope, but suppose it would be great if someone could tell me the story behind signed segment size as I see it is better unsigned.

Kind regards,
Ian Ilyasov.

Junior Software Developer at Postgres Professional

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2025-02-04 16:46:01 Re: Add a warning message when using unencrypted passwords
Previous Message Nathan Bossart 2025-02-04 16:30:58 add missing PQfinish() calls to vacuumdb