Re: Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Gurjeet Singh <gurjeet(at)singh(dot)im>
Cc: Kevin Grittner <kgrittn(at)ymail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.
Date: 2014-07-02 15:06:10
Message-ID: CA+TgmoardYqDETNQ3WRCkDksWr8UaBRZJF-5qMG1-TyHLXMPKA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 1, 2014 at 7:32 PM, Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
> On Tue, Jul 1, 2014 at 10:05 AM, Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
>> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>>> If we're going to do it like this, then I think the force flag
>>> should be considered to do nothing except override the clock
>>> check, which probably means it shouldn't be tested in the initial
>>> if() at all.
>>
>> That makes sense, and is easily done.
>
> Attached is the patch to save you a few key strokes :)
>
>> The only question left is
>> how far back to take the patch. I'm inclined to only apply it to
>> master and 9.4. Does anyone think otherwise?
>
> Considering this as a bug-fix, I'd vote for it to be applied to all
> supported releases. But since this may cause unforeseen performance
> penalty, I think it should be applied only as far back as the
> introduction of PGSTAT_STAT_INTERVAL throttle.
>
> The throttle was implemeted in 641912b, which AFAICT was part of 8.3.
> So I guess all the supported releases it is.

I'll vote for master-only. I view this as a behavior change, and it
isn't nice to spring those on people in minor releases.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2014-07-02 15:10:30 Re: 9.5 CF1
Previous Message Robert Haas 2014-07-02 15:01:41 Re: RLS Design