Re: Reject incompatible options specified with VACUUM ONLY_DATABASE_STATS

From: Ishjaap Singh <ishjaap(dot)singh07(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Reject incompatible options specified with VACUUM ONLY_DATABASE_STATS
Date: 2026-11-21 09:37:40
Message-ID: CA+Y2BmeXaLUKsF4BpMmzD+cRCoDoMjmJkAbmEesGvQQvk7R-NQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 26, 2026, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> So, I'd leave the v1 implementation as it is and wait for more
> opinions.

Hi Chao,

I tested v3 on master (207b5293b8d) against an unpatched build. make
check and 100_vacuumdb.pl pass. PARALLEL, INDEX_CLEANUP, TRUNCATE and
BUFFER_USAGE_LIMIT are now rejected with ONLY_DATABASE_STATS.

Rejecting options given as off (PARALLEL 0, PROCESS_TOAST false, ...)
seems fine to me for master; it matches how FULL handles
BUFFER_USAGE_LIMIT. vacuumdb only sends a bare
VACUUM (ONLY_DATABASE_STATS), and it still works with all the flags I
tried.

Optionally, a test for VACUUM (ONLY_DATABASE_STATS, PARALLEL 0) would
cover the presence-over-value choice.

Looks good to me.

Thanks,
Ishjaap Singh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-11-21 10:06:12 Re: Backend crash in expanded_record_info functions
Previous Message Ishjaap Singh 2026-11-21 08:58:40 Re: Fix jsonpath printing of operations followed by an accessor