Re: Use strtoi64() in pgbench, replacing its open-coded implementation

From: Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use strtoi64() in pgbench, replacing its open-coded implementation
Date: 2025-11-20 01:04:36
Message-ID: CAA3qoJnvD7Av5gTkPF++isGU2xcjdq5M5ndR0xcFwR96Ro0b1g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, Nov 20, 2025 at 8:57 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:

> Here's a small patch to replace the int64 parsing code in pgbench with a
> call to strtoi64(). Makes it a little simpler.
>
>
+1 on this simplification – it definitely makes the code cleaner.
One small note: the updated code doesn’t handle trailing spaces in the
input string. Should we consider this a concern?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-11-20 01:23:01 Re: PRI?64 vs Visual Studio (2022)
Previous Message Fujii Masao 2025-11-20 01:03:20 Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis