| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactoring: Use soft error reporting for *_opt_overflow functions of date/timestamp |
| Date: | 2025-11-28 04:16:43 |
| Message-ID: | CAAJ_b94sNMr5s8nQfua_L7eBzZKxtXZuwOg1968a37gZo+R3CQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 28, 2025 at 6:16 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Nov 27, 2025 at 06:18:32PM +0900, Amit Langote wrote:
> > On Thu, Nov 27, 2025 at 4:58 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> >> One question: Regarding date2timestamp_no_overflow(), should we rename
> >> it to date2double? We can't use date2timestamp_safe because we already
> >> have that function. The renaming is relevant because this function
> >> converts a date to the double data type, which allows us to remove the
> >> "_no_overflow" extension.
> >
> > Makes sense to me.
>
> Yes, it would be nice to change all this area at once to remain
> consistent across the board. date2timestamp_no_overflow() is the last
> "no_overflow" routine in date.h.
I have attached patch 0002 that renames it. I also updated patch 0001
to accommodate Amit's comment suggestions.
Regards,
Amul
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Switch-some-date-related-functions-to-use-soft-er.patch | application/octet-stream | 15.2 KB |
| v2-0002-Rename-date2timestamp_no_overflow-to-date2double.patch | application/octet-stream | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-11-28 04:27:53 | Re: Simplify code building the LR conflict messages |
| Previous Message | jian he | 2025-11-28 04:09:17 | extend JSON_TABLE top level path expression |