| From: | Sugamoto Shinya <shinya34892(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |
| Date: | 2025-11-12 13:23:34 |
| Message-ID: | CAAe3y+_cJgyhWgSNQ8Xs83WDF6UsdgD57LboZ9jX+AcaAtX4eg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 12, 2025 at 10:56 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Nov 12, 2025 at 10:10 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
> wrote:
> > +1 for hard-coding the supported encoding list. I think it's a good
> > start point. We can revisit the idea of dynamically constructing the
> > encoding list if we're concerned about its maintenance cost.
>
> +1
>
> Regards,
>
> --
> Fujii Masao
>
Thanks everyone for reviewing my proposal.
I've hard-coded the valid list of encoding names.
Also, I modified the hint string into like "Valid encodings are \"hex\",
\"base64\", \"base64url\", and \"escape\"."
by adding "and" before "escape".
I attached my v2 patch to this message. Please let me know freely if you
have any additional questions.
Regards,
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Added-error-hints-for-invalid-binary-encoding-names-.patch | application/octet-stream | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2025-11-12 13:26:50 | Re: Include extension path on pg_available_extensions |
| Previous Message | Григорий Новиков | 2025-11-12 13:05:18 | [PATCH] Add cascade synchronous replication |