| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Wrong results with initplans moved by setrefs.c |
| Date: | 2026-11-09 07:36:17 |
| Message-ID: | CAApHDvqOezFfxKXHp1tv5qat9BHcUtLn2iJRsEwf5ex0A3U7qw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 9 Nov 2026 at 19:30, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> On Mon, Nov 9, 2026 at 2:11 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > Looking at finalize_plan(), I'd say that's correct. But shouldn't it
> > be bms_add_member() rather than bms_union()?
>
> Thanks for looking! I assume you mean bms_add_members().
Yeah. I did mean to type that.
> Attached is a patch for this fix.
>
> (Since v14 will reach EOL before this can be pushed, maybe
> back-patching to v15 is enough.)
Looks mostly ok. I'd use "add" instead of "merge" in "To fix, merge
the removed", and I expect "Backpatch-through: 14" should be 15.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 민영재 | 2026-11-09 07:45:42 | Re: BUG #19736: `JSON_OBJECT ... ABSENT ON NULL` accepts invalid keys when the value is NULL |
| Previous Message | Richard Guo | 2026-11-09 07:14:42 | Re: Wrong results with references to JOIN USING aliases |