| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Marko Grujic <marko(dot)grujic(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Marko Grujic <markoog(at)gmail(dot)com> |
| Subject: | Re: [PATCH v1] [BUG #19516] Skip whole-row projection shortcut for OLD/NEW returning type |
| Date: | 2026-06-11 11:24:14 |
| Message-ID: | CAEZATCWw9-3xvk74Oj_k4wp36s0QRusWyQOa2-HpDP3bC315Ow@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 10 Jun 2026 at 15:08, Marko Grujic
<marko(dot)grujic(at)enterprisedb(dot)com> wrote:
>
> > So I think a better solution would be to add a new function
> GetNSItemByVar(), similar to GetNSItemByRangeTablePosn()
>
> Alright, produced a v2 patch with this approach now (attached).
>
> It also fixes the star expansion when RETURNING parenthesized OLD/NEW rows (added test cases to exercise that as well).
>
> Let me know how it looks.
>
Looks good, thanks.
Pushed and back-patched to v18.
I condensed the tests down a bit, and added a comment note to
GetNSItemByRangeTablePosn() suggesting that callers should consider
GetNSItemByVar() instead, in case any new code is written that might
need it.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stolpovskikh Danil | 2026-06-11 11:44:32 | [PATCH] fix AddRelsyncInvalidationMessage |
| Previous Message | Amit Kapila | 2026-06-11 11:18:08 | Re: Fix race in ReplicationSlotRelease for ephemeral slots |