| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix use of variable after pfree |
| Date: | 2025-09-02 08:56:26 |
| Message-ID: | CAF13D2F-E01F-4203-8EE6-254564AFCD90@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 2 Sep 2025, at 09:42, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Sep 2, 2025 at 1:02 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>> While going through the code of the slot sync worker, I found that in
>> functions ReplSlotSyncWorkerMain and pg_sync_replication_slots the
>> variable app_name.data is being used after it is freed.
>>
>> We can get logs as following:
>> 2025-09-02 12:26:48.520 IST [3908359] ERROR: synchronization worker
>> "" could not connect to the primary server: connection to server at
>> "localhost" (127.0.0.1), port 5432 failed: Connection refused
>> Is the server running on that host and accepting TCP/IP connections?
>>
>> I have moved the pfree(app_data.name) after its usage.
>>
>> This change was introduced in PG_18.
>> The patch applies in the HEAD and REL_18_STABLE branches.
>
> Thanks for the patch. It looks good to me. I'll take care of it.
Agreed, this looks correct.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2025-09-02 09:02:41 | Re: Extension security improvement: Add support for extensions with an owned schema |
| Previous Message | Chao Li | 2025-09-02 08:42:24 | Fix pg_waldump to exit cleanly at end of WAL |