Re: [PG19-3 PATCH] Don't ignore passfile

From: Paul Ohlhauser <bendix(dot)ohlhauser(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, postgresql(dot)cache976(at)passmail(dot)net, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PG19-3 PATCH] Don't ignore passfile
Date: 2025-09-08 15:20:19
Message-ID: CAGbOXJH3J2-ep3c8cMLTOph9cqi_6y1cjV+x8yOTxXsLpDq7tQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Would it address your concern if we reworded that error message to be
> more clear that the file is going to be ignored? I think that proposal
> would have a better chance of success than this one.
Yes, that would improve it a bit. I already suggested this in my very first
message.
To reiterate:
I see three problems:
- A.) Postgres unintuitively continues with a broken configuration
- B.) Postgres does not at least inform the user that the passfile is
ignored
- C.) Group permissions are not allowed

And I propose one or more of the following solutions:
- 1. Make the warning clearer by stating that passfile is ignored (B)
- 2. Change the warning to be an error (A,B)
- 3. Allow group permissions (C)
- 4. Just warn, don't ignore (A,B,C)

Option 4 is the easiest and the patch I submitted but does not seem to be
well received
Option 1 is the bare minimum IMO - it's still not great though
I'd like to see options 2 & 3 (same behavior as SSH)

Am Mo., 8. Sept. 2025 um 15:36 Uhr schrieb Robert Haas <
robertmhaas(at)gmail(dot)com>:

> On Sat, Sep 6, 2025 at 9:52 AM Paul Ohlhauser
> <bendix(dot)ohlhauser(at)gmail(dot)com> wrote:
> > My point is not that the user is not happy, that they have to change
> permissions.
> > It is that the user would rather get a clear error message than to get
> two separate messages (warning that doesn't mention "ignore" and
> authentication error) they need to connect to understand what is going on.
>
> Would it address your concern if we reworded that error message to be
> more clear that the file is going to be ignored? I think that proposal
> would have a better chance of success than this one.
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2025-09-08 15:23:03 Re: Only one version can be installed when using extension_control_path
Previous Message David E. Wheeler 2025-09-08 15:17:51 Re: ABI Compliance Checker GSoC Project