Re: Remove Instruction Synchronization Barrier in spin_delay() for ARM64 architecture

From: Salvatore Dipietro <dipietro(dot)salvatore(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Salvatore Dipietro <dipiets(at)amazon(dot)com>, blakgeof(at)amazon(dot)com
Subject: Re: Remove Instruction Synchronization Barrier in spin_delay() for ARM64 architecture
Date: 2025-05-13 18:37:45
Message-ID: CAGnuAhXoZHyf-=JNC=eJYyitOx36P_F0sTsAH2wj2FQz0U7KSw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 1 May 2025 at 14:50, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> So...
>
> * The ISB does seem to have a positive effect without commit 3d0b4b1
> applied.
>
> * With commit 3d0b4b1 applied, removing the ISB seems to have a positive
> effect at high concurrencies. This is especially pronounced in the
> pgbench test.
>
> * With commit 3d0b4b1 applied, removing the ISB doesn't change much at
> lower concurrencies, and there might even be a small regression.
>
> * At mostly lower concurrencies, commit 3d0b4b1 actually seems to regress
> some test_shm_mq tests. Removing the ISB instruction appears to help in
> some cases, but not all.

Based on your findings Nathan, what is the best way to proceed for this change?
Do we need more validation for it? If yes, which kind?

Thanks,
Salvatore

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mihail Nikalayeu 2025-05-13 20:11:49 Re: Allow reading LSN written by walreciever, but not flushed yet
Previous Message David E. Wheeler 2025-05-13 18:07:10 Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part