Re: Maintaining a list of pgindent commits for "git blame" to ignore

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Maintaining a list of pgindent commits for "git blame" to ignore
Date: 2021-03-18 23:03:29
Message-ID: CAH2-Wzn=JRwVMPOmYB7v+YzEWnesTqDCqmo26-Bqbx1YeHM-hg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 18, 2021 at 4:00 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Probably because later commits might collide with shorter hashes. When
> you are reporting a hash that only looks _backward_, this is not an
> issue.

Right, but it's extremely unlikely to happen by accident. I was
suggesting that there might be a security issue. I could fairly easily
make my git commit match a prefix intended to uniquely identify your
git commit if I set out to do so.

There are projects that might have to consider that possibility,
though perhaps we're not one of them.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-03-18 23:05:03 Re: Maintaining a list of pgindent commits for "git blame" to ignore
Previous Message Bruce Momjian 2021-03-18 23:00:00 Re: Maintaining a list of pgindent commits for "git blame" to ignore