Re: Segmentation fault on proc exit after dshash_find_or_insert

From: Rahila Syed <rahilasyed90(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Segmentation fault on proc exit after dshash_find_or_insert
Date: 2025-12-17 10:36:58
Message-ID: CAH2L28to0CbBWeSKvinp6wFrwX-ZBMqbGQ3_1Bkyits+yn_w_Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Amit,

> /*
> * Release any LWLocks we might be holding, before running callbacks
> that
> - * may detach the memory containing those locks.
> + * may detach the memory containing those locks. Releasing all the
> locks
> + * ensures that any callbacks executed afterward will be able to
> acquire
> + * any lock.
> */
>
> Hmm, I'm not sure I follow. Maybe it has to do with something you
> were trying to do when you ran into this bug, but why would callbacks
> be acquiring locks after an error and why would it be safe to do so?
>

It seems common for both before and on shmem exit callbacks to acquire
locks.
For instance, RemoveTempRelationsCallback eventually calls performDeletion,
which acquires an LW lock.

> Are you saying that LWLockReleaseAll() cleans up unsafe-to-access
> locks so that new ones can be taken after that point?
>

Yes, what I mean is that acquiring a lock within a callback will work,
regardless of whether it was held when the error occurred, since we ensure
all locks are released before executing the callbacks.

Thank you,
Rahila Syed

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-12-17 10:39:05 Re: Remaining dependency on setlocale()
Previous Message Zhijie Hou (Fujitsu) 2025-12-17 10:28:28 RE: Improve pg_sync_replication_slots() to wait for primary to advance