| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Manu <manuelreyesbravo(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Assertion failure with temporary relations in single-user mode |
| Date: | 2026-11-17 04:41:36 |
| Message-ID: | CAHGQGwE0nhCjM53yWZjz8_uYPjSjxbYohvTxkZiWD2U8r6p-Tg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 17, 2026 at 9:32 AM Manu <manuelreyesbravo(at)gmail(dot)com> wrote:
> Patch with a test attached; the test also fails without assertions.
Thanks for the report and patch!
The fix in pgstat_io.c seems good to me.
I wonder if adding a new TAP test file might be overkill for this fix.
Several similar fixes for assertion failures in single-user mode have
not included tests.
Using temporary tables in single-user mode seems uncommon,
so I'm not sure a dedicated test provides enough value to justify
the additional test runtime.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2026-11-17 04:57:13 | [DEPARSE] A JSON DEFAULT cast to a length-limited RETURNING type truncates after restore |
| Previous Message | Sami Imseih | 2026-11-17 04:39:26 | Re: Improve pg_stat_statements scalability |