| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Subject: | Re: to_hex() for negative inputs |
| Date: | 2023-01-24 13:42:56 |
| Message-ID: | CAJ7c6TNfbbcqZbw03oxN7-U0h2oU=kwoqoHJG5LdU8e3r7zdoQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Dean,
> I only recently realised that to_hex() converts its input to unsigned
> before converting it to hex (something that's not mentioned in the
> docs):
Technically the documentation is accurate [1]:
"""
Converts the number to its equivalent hexadecimal representation.
"""
But I agree that adding an example with negative numbers will not
hurt. Would you like to submit a patch?
> I also think it might be useful for it to gain a couple of boolean options:
Adding extra arguments for something the user can implement
(him/her)self doesn't seem to be a great idea. With this approach we
may end up with hundreds of arguments one day.
> 1). An option to output a signed value (defaulting to false, to
> preserve the current two's complement output).
This in particular can be done like this:
```
=# select case when sign(x) > 0 then '' else '-' end || to_hex(abs(x))
from ( values (123), (-123) ) as s(x);
?column?
----------
7b
-7b
(2 rows)
```
> 2). An option to output the base prefix "0x" (which comes after the
> sign, making it inconvenient for the user to add themselves).
Ditto:
```
=# select '0x' || to_hex(x) from ( values (123), (-123) ) as s(x);
?column?
------------
0x7b
0xffffff85
```
[1]: https://stream.boxwatch.ru/docs/current/functions-string.html
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-01-24 13:50:42 | Re: Non-superuser subscription owners |
| Previous Message | Melanie Plageman | 2023-01-24 13:38:58 | Re: Monotonic WindowFunc support for ntile(), percent_rank() and cume_dist() |