| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Conflict detection for update_deleted in logical replication |
| Date: | 2025-06-12 10:52:12 |
| Message-ID: | CAJpy0uB+Xany=2TZjtGg+FD_OQGj+0RP8tUNk+pnaiBnNmXe9w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 12, 2025 at 11:34 AM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
>
> Here is the V35 patch set which includes the following changes:
>
Thank You for the patches. Few comments:
1)
Since now we create slot for rci enabled subscription, it will require
wal_level >= replica even on subscribers. We shall mention this in the
docs.
2)
postgres=# alter subscription sub3 set (retain_conflict_info=true);
NOTICE: deleted rows will continue to accumulate for detecting
conflicts until the subscription is enabled
ALTER SUBSCRIPTION
postgres=# alter subscription sub3 disable;
WARNING: deleted rows to detect conflicts would not be removed until
the subscription is enabled
HINT: Consider setting retain_conflict_info to false.
I feel we shall have the same message in both the cases as we are
trying to convey the exact same thing concerning deleted rows
accumulation..
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-06-12 11:03:13 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Previous Message | shveta malik | 2025-06-12 10:46:29 | Re: Question on error code selection in conflict detection |