Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Japin Li <japinli(at)hotmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Date: 2025-12-19 12:30:36
Message-ID: CALdSSPjwb8wzT+a8nHM3Vt=i+YEARKWeG53+CD8TeUiwVMV4kA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 19 Dec 2025 at 16:05, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Fri, Dec 19, 2025 at 7:07 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> > Thanks for the patch — that was my oversight.
> >
> > LGTM with one small suggestion:
>
> Thanks for the review!
>
> > The comment says: "If the option is not found in connInfo, return NULL value."
> >
> > Since the parameter is named `keyword`, I'd suggest: "If the keyword is not found in connInfo, return NULL."
> >
> > This keeps terminology consistent with the function signature.
>
> I think "the option with the given keyword" is more precise than just
> "the keyword".
> That said, simply using "the option" also seems sufficient in this context...
>
>
> Regarding 0002 patch, I found that it caused a CI failure, so I’ve updated
> the patch to fix that. The revised patch is attached.
>
> Regards,
>
> --
> Fujii Masao

Hi!
I checked the new TAP test 0002 changes. I am wondering, why are
connection options validated so late in this test? I mean, we do
ALTER PUBLICATION, then we restart publisher, wait for catchup, check
alter publication, and etc, and only then we look if connection
options are indeed applied?

--
Best regards,
Kirill Reshke

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matheus Alcantara 2025-12-19 13:45:29 Re: Asynchronous MergeAppend
Previous Message Heikki Linnakangas 2025-12-19 11:51:09 Re: A few patches to clarify snapshot management, part 2