Re: [PATCH] Add `headerscheck` run_target to meson

From: Miłosz Bieniek <bieniek(dot)milosz0(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Add `headerscheck` run_target to meson
Date: 2025-11-28 12:58:01
Message-ID: CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV+0mdP0g9V8va=K0YA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

pt., 28 lis 2025 o 12:53 Peter Eisentraut <peter(at)eisentraut(dot)org> napisał(a):
>
> On 27.11.25 10:28, Miłosz Bieniek wrote:
> > While reviewing a patch I noticed that we have a `make -s headerscheck`
> > but there is no equivalent in meson.
> > I prepared a small patch that adds `headerscheck` and `cpluspluscheck`
> > targets.
>
> This would be good to have, but I don't think your patch works. It
> seems you need to add the srcdir and builddir command-line arguments to
> the invocations.
>

I think you are right. I added srcdir and builddir arguments.

Attachment Content-Type Size
v2-0001-Add-headerscheck-run_target-to-meson.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-11-28 12:59:01 Re: headerscheck ccache support
Previous Message Nazir Bilal Yavuz 2025-11-28 12:34:33 Re: headerscheck ccache support