| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Jan Nidzwetzki <jan(at)planetscale(dot)com> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org, Tom Pang <tom(at)planetscale(dot)com> |
| Subject: | Re: pg_rewind and hint bits leads to visibility corruption |
| Date: | 2026-11-21 09:22:38 |
| Message-ID: | CAN4CZFNXY4C7KyOE2ZFdc=L6-i-6bkE+ye8o9Y_L1x_DbfG_6A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hello
1. On Fri, 20 Nov 2026, Jan Nidzwetzki <jan(at)planetscale(dot)com> wrote:
> and an index-only scan after a promotion, which wrote 1.338 GB of
> WAL instead of 1.317 GB.
Depending on the workload, this can be much more significant: with the
patch a standby after promotion, but before the first checkpoint will
write all accessed previous dirty pages into the WAL as full page
writes. Depending on how many dirty pages it has, and what queries are
executed on it, this can possibly result in a huge wal burst. I'm not
saying that this is a blocker, it is possibly acceptable, but it is
something that should be pointed out.
2. Another performance issue: a clean restart of the primary disables
the xid exemption on the standby
Shutdown checkpoints carry an Invalid oldestActiveXid. If that is the
first replayed checkpoint after a page's LSN, every hint on that page
is refused, even for long-committed rows. That lasts until a
restartpoint, even if online checkpoints follow. This triggers the FPI
case in (1), but it also causes a measurable performance degradation
in queries during normal standby operation.
And while testing this I found a different issue: pg_rewind can't
detect properly a mixed wal_log_hint_bits cluster if data checksums
are also off, and operates in scenarios it shouldn't be; I'll create a
separate thread about that
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2026-11-21 12:31:08 | Re: BUG #19912: MERGE NOT MATCHED BY SOURCE sees stale source values after concurrent update (EPQ) |
| Previous Message | PG Bug reporting form | 2026-11-21 09:00:00 | BUG #19928: pg_upgrade fails on v18 schema with NOT NULL ... NO INHERIT and inheritance |