| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: GiST README typos |
| Date: | 2025-11-06 09:38:31 |
| Message-ID: | CANWCAZbiVYq+2cR0swO45czKXv8-cLch-51mSSrtBcFy88U80w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 6, 2025 at 1:36 PM Paul A Jungwirth
<pj(at)illuminatedcomputing(dot)com> wrote:
>
> On Wed, Nov 5, 2025 at 7:00 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> >
> > being empty. Whenever we find one, we acquire a lock on the parent and child
> > -page, re-check that the child page is still empty. Then, we remove the
> > +page, then re-check that the child page is still empty. Then, we remove the
> > downlink and mark the child as deleted, and release the locks.
> >
> > I still find this a bit awkward -- perhaps "and re-check"? The last
> > sentence could do with just the last "and" as well, I think, but
> > that's a style consideration and not a grammar fix.
>
> I nearly wrote it that way myself. It's nice that it avoids the double
> "then". So I agree, let's go with "and re-check".
Pushed that way, thanks!
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2025-11-06 10:05:20 | Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue |
| Previous Message | Andreas Karlsson | 2025-11-06 09:37:40 | Re: ago(interval) → timestamptz |