Re: Stop masking visibility information during WAL consistency checking

From: surya poondla <suryapoondla4(at)gmail(dot)com>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Zhijie Hou <houzhijie22(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Stop masking visibility information during WAL consistency checking
Date: 2026-11-20 21:30:04
Message-ID: CAOVWO5qdV23ZHAkLO23L12HvSrSt2az6Bc+OOCLHpwiQY-raSA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Melanie,

Thank you for starting this thread and the patches.

I tested v1 0001+0002 on master (65ebed1f5e2) and did a couple of tests:
1. make check passes, including the new test_vm_mask().
2. Primary with wal_consistency_checking = all plus a streaming standby,
running the regression suite against the primary (similar to
027_stream_regress with PG_TEST_EXTRA=wal_consistency_checking, huge
wal was generated), the standby replayed everything with no
inconsistent-page failures.
3. Crash recovery with wal_consistency_checking = all over a workload aimed
at VM/PD_ALL_VISIBLE transitions (VACUUM and VACUUM FREEZE, VM clears from
UPDATE/DELETE/row locks, on-access pruning, COPY FREEZE, VM truncation)
they all look clean.

I didn't see any false positives from unmasking either the VM bitmap or
PD_ALL_VISIBLE.

Otherwise both patches look good to me.

Regards,
Surya Poondla

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-11-20 22:34:36 Re: Checkpoints stuck after a failed bulk write inside a savepoint
Previous Message Melanie Plageman 2026-11-20 20:44:07 Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts