| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Few untranslated error messages in OAuth |
| Date: | 2025-11-13 23:08:44 |
| Message-ID: | CAOYmi+moRTv+qhE8X1CMX5azz3DOsKFBadoW_hqvAQocUO4S9g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 13, 2025 at 8:23 AM Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> On Thu, Nov 13, 2025 at 4:49 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > If so, should that be extended to oauth_json_set_error as well? (and possibly others?)
>
> That should be covered already by nls.mk, unless I messed that up
> too... I'll do a deeper dive.
I misread your email, sorry. We trigger on oauth_parse_set_error(),
but not oauth_json_set_error(). I'll see how easy that is to change.
There's more to fix here, after talking with Alvaro offlist. I got
gettext to tell me [1] what else was missing and found that
- fe-auth-oauth.c is not in GETTEXT_FILES at all
- I didn't give jsonapi.c the same handling as in 3ddbac368 when I
ported it to libpq, so it's not translated either
I'm writing up a patch that combines all of that.
Thanks,
--Jacob
[1] https://www.gnu.org/software/gettext/manual/html_node/Prioritizing-messages.html
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-11-13 23:30:22 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Tomas Vondra | 2025-11-13 22:36:06 | Re: Performance issues with parallelism and LIMIT |