| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Drop slot's LWLock before returning from SaveSlotToPath() |
| Date: | 2020-03-26 13:16:01 |
| Message-ID: | E1jHSMb-00087S-5r@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Drop slot's LWLock before returning from SaveSlotToPath()
When SaveSlotToPath() is called with elevel=LOG, the early exits didn't
release the slot's io_in_progress_lock.
This could result in a walsender being stuck on the lock forever. A
possible way to get into this situation is if the offending code paths
are triggered in a low disk space situation.
Author: Pavan Deolasee <pavan(dot)deolasee(at)2ndquadrant(dot)com>
Reported-by: Craig Ringer <craig(at)2ndquadrant(dot)com>
Discussion: https://stream.boxwatch.ru/message-id/flat/56a138c5-de61-f553-7e8f-6789296de785%402ndquadrant.com
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2d8597ba66a1646e353c0ff755b4b0b85cd1747f
Modified Files
--------------
src/backend/replication/slot.c | 9 +++++++++
1 file changed, 9 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-03-26 13:50:11 | Re: pgsql: Provide a TLS init hook |
| Previous Message | Andrew Dunstan | 2020-03-26 11:01:39 | Re: pgsql: Provide a TLS init hook |