RE: [PATCH] pg_upgrade: add hints to wal_level and max_replication_slots checks

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Joao Rito' <joaovictor(dot)rito(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: [PATCH] pg_upgrade: add hints to wal_level and max_replication_slots checks
Date: 2026-11-19 01:59:32
Message-ID: OS7PR01MB18317465AC53232FAB8E62BFCF5792@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Joao,

> While reading check_new_cluster_replication_slots() in pg_upgrade, I saw that
> some errors say a setting is wrong but do not say what to change or in which
> cluster. For example:
>
> "wal_level" must be "replica" or "logical" but is set to "minimal"
> "max_replication_slots" (0) must be greater than or equal to the number of
> logical replication slots (1) in the old cluster

Hmm. For me it's quite clear which value must be updated to what.
In core code like CheckSubDeadTupleRetention(), the primary error message just says
wal_level is sufficient; thus it made sense to print a HINT message. However, I don't think
suggested HINT provides more information to user here.

FYI, PostgreSQL community prefer to attach .patch files. See [1].

[1]: https://wiki.postgresql.org/wiki/Submitting_a_Patch

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2026-11-19 02:54:15 Re: [PATCH] doc: Fix autovacuum_max_workers and autovacuum_worker_slots descriptions
Previous Message Joao Rito 2026-11-19 01:45:13 [PATCH] pg_createsubscriber: add hint to wal_level error