| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reset snapshot export state on the transaction abort |
| Date: | 2021-10-14 06:54:29 |
| Message-ID: | YWfUJYaEuHuWw0mq@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 13, 2021 at 10:53:24AM +0530, Dilip Kumar wrote:
> Actually, it is not required because 1) Snapshot export can not be
> allowed within a transaction block, basically, it starts its own
> transaction block and aborts that while executing any next replication
> command see SnapBuildClearExportedSnapshot(). So our problem is only
> if the transaction block internally started for exporting, gets
> aborted before any next command arrives. So there is no possibility
> of starting any sub transaction.
Yes, you are right here. I did not remember the semantics this relies
on. I have played more with the patch, reviewed the whole, and the
fields you are resetting as part of the snapshot builds seem correct
to me. So let's fix this.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2021-10-14 07:48:12 | Re: Next Steps with Hash Indexes |
| Previous Message | osumi.takamichi@fujitsu.com | 2021-10-14 06:13:18 | RE: Failed transaction statistics to measure the logical replication progress |