Re: Making pglister work with exim 4.96+

From: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
To: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>, Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: Making pglister work with exim 4.96+
Date: 2024-06-17 11:01:10
Message-ID: a79ad224-6c94-48f6-a1bd-81595b880c61@kaltenbrunner.cc
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-www

On 17.06.24 12:57, Célestin Matte wrote:
> Update:
> Fix for pgarchives' load_message.py is pretty straightforward: exim
> provides the untainted version of $local_part, $local_part_data. Same
> for $domain and $domain_data.
> Pglister's inject.py is a tougher situation. I can't seem to get an
> untainted version of $sender_address and $header_message-id.
>
> However, replacing them with fake values does get things delivered
> properly. I'm starting to wonder if we really need these values. Why
> does inject.py need them for exactly? Header-message-id seems to only be
> displayed in the moderation queue, and sender address is correctly
> retrieved anyway (or is it just for the "envelope:" field of the
> moderation queue?).
>
>> Maybe we could have a switch to inject that picks these up from the
>> environment: I *think* most of those are actually made available by
>> default as environment variables in exim if I understand
>> https://www.exim.org/exim-html-current/doc/html/spec_html/ch-the_pipe_transport.html <https://www.exim.org/exim-html-current/doc/html/spec_html/ch-the_pipe_transport.html> point 4 correct. Or would those have the same problems with tainting?
>>
>> AIUI the only thing we couldn't get that way might be the message-id?
>> The question is, can we add that to the environment without getting
>> into taint problems?
>
> Can't get that to work (${env{SENDER_ADDRESS}} or SENDER is replaced by
> an empty value). I could keep trying, but that still wouldn't solve the
> problem for $header_message-id.

SENDER_ADDRESS is not among the default set of environment variables -
did you actually add them in the pipe transport using an environment =
stanza?

Stefan

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2024-06-17 11:11:34 Re: Making pglister work with exim 4.96+
Previous Message Célestin Matte 2024-06-17 10:57:17 Re: Making pglister work with exim 4.96+