Re: queryId constant squashing does not support prepared statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Sami Imseih <samimseih(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: queryId constant squashing does not support prepared statements
Date: 2025-05-09 05:35:33
Message-ID: aB2UJSi2ZQrZ4lnY@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 09, 2025 at 11:05:43AM +0800, Junwang Zhao wrote:
> Why not a location and a length, it should be more natural, it
> seems we use this convention in some existing nodes, like
> RawStmt, InsertStmt etc.

These are new concepts as of Postgres 18 (aka only on HEAD), chosen
mainly to match with the internals of pg_stat_statements as far as I
recall. Doing the same here would not hurt, but it may be better
depending on the cases to rely on a start/end. I suspect that
switching from one to the other should not change much the internal
squashing logic.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2025-05-09 05:54:37 Re: Assert failure in base_yyparse
Previous Message Michael Paquier 2025-05-09 05:08:26 Re: Issues with 2PC at recovery: CLOG lookups and GlobalTransactionData