Re: queryId constant squashing does not support prepared statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: queryId constant squashing does not support prepared statements
Date: 2025-05-01 22:10:19
Message-ID: aBPxS58PWgpNrWUB@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 01, 2025 at 03:57:16PM -0500, Sami Imseih wrote:
> I think what we should really allow the broader scope of expressions that
> are allowed via prepared statements, and this will make this implementation
> consistent between prepared vs non-prepared statements. I don't see why
> not. In fact, when we are examining the ArrayExpr, I think the only
> thing we should
> not squash is if we find a Sublink ( i.e. SELECT statement inside the array ).

Likely so. I don't have anything else than Sublink in mind that would
be worth a special case..

> I am really leaning towards that we should revert this feature as the
> limitation we have now with parameters is a rather large one and I think
> we need to go back and address this issue.

I am wondering if this would not be the best move to do on HEAD.
Let's see where the discussion drives us.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Salvatore Dipietro 2025-05-01 22:16:17 Re: Remove Instruction Synchronization Barrier in spin_delay() for ARM64 architecture
Previous Message Nathan Bossart 2025-05-01 21:50:36 Re: Remove Instruction Synchronization Barrier in spin_delay() for ARM64 architecture