Re: Trivial patch to fix a typo

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Trivial patch to fix a typo
Date: 2025-08-01 07:04:23
Message-ID: aIxm99zvtisatRS7@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 01, 2025 at 02:56:33PM +0800, Chao Li wrote:
> I happened to catch this typo while reading the regression test code, so
> submitting a fix.
>
> As the typo is in the code comment, no test needs to run.

Incorrect. The comment is included in the generated output, impacting
also foreign_key.out. If you run a simple `make check` you would see
that the tests fail.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-08-01 07:16:18 Re: Trivial patch to fix a typo
Previous Message Chao Li 2025-08-01 07:03:45 Re: When creating index, why pointing to old version of tuple