Re: Move WAL/RMGR sequence code into its own file and header

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Move WAL/RMGR sequence code into its own file and header
Date: 2025-11-28 04:05:55
Message-ID: aSkfo8MTspUnlkt-@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 27, 2025 at 12:00:30PM +0300, Kirill Reshke wrote:
> Shouldnt `SEQ_LOG_VALS` be moved to sequnce_xlog.c ?

I am not sure to follow this one. This controls the frequency of the
records inserted, which has nothing to do with the redo path.

> Also, while on it, maybe it is worth to rename xl_seq_rec struct to
> something. It will be more convenient to make a name in sync with the
> XLOG_SEQ_LOG WAL record (like we do in heapxlog). Maybe struct
> xl_seq_log ?

I am not sure to see the value in a rename for the scope of this
patch, sequence.h already published them.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-11-28 04:09:17 extend JSON_TABLE top level path expression
Previous Message Peter Smith 2025-11-28 03:59:01 Fix a recent "shadow warning" in subscriptioncmds.c