Re: Fix memory leak in gist_page_items() of pageinspect

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix memory leak in gist_page_items() of pageinspect
Date: 2025-12-18 23:01:54
Message-ID: aUSH4oyxfLSpRRZ4@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 17, 2025 at 11:57:13AM +0000, Bertrand Drouvot wrote:
> Please note that for hash_bitmap_info() and pgstathashindex() the open calls are
> changed instead. For those we keep the IS_INDEX() checks to reject partitioned
> indexes (which index_open() accepts via validate_relation_kind()). So, that also
> changes the error messages in some tests. If we do prefer the previous error
> messages we could change the close calls instead (I prefer the way it's done
> in the attached though).

I have noticed that the two surrounding relation_close() calls for the
parent tables did not get the notice of the change for brin.c of what
you are doing for the indexes, while we use table_open(). I have
fixed these.

It would be nicer if IS_INDEX() could be removed in the other code
paths you are suggesting to change, but the partitioned index argument
also means that we would have two code paths in charge of a relkind
check instead of one. Just using relation_*() may be cleaner.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-12-18 23:07:53 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Michael Paquier 2025-12-18 22:44:03 Re: Fwd: [PATCH] Add zstd compression for TOAST using extended header format